Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: src/debug.cc

Issue 1207583002: Revert "Keep a canonical list of shared function infos." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2063 matching lines...) Expand 10 before | Expand all | Expand 10 after
2074 2074
2075 // There will be at least one break point when we are done. 2075 // There will be at least one break point when we are done.
2076 has_break_points_ = true; 2076 has_break_points_ = true;
2077 2077
2078 // If the candidate found is compiled we are done. 2078 // If the candidate found is compiled we are done.
2079 done = target->is_compiled(); 2079 done = target->is_compiled();
2080 if (!done) { 2080 if (!done) {
2081 // If the candidate is not compiled, compile it to reveal any inner 2081 // If the candidate is not compiled, compile it to reveal any inner
2082 // functions which might contain the requested source position. This 2082 // functions which might contain the requested source position. This
2083 // will compile all inner functions that cannot be compiled without a 2083 // will compile all inner functions that cannot be compiled without a
2084 // context, because Compiler::GetSharedFunctionInfo checks whether the 2084 // context, because Compiler::BuildFunctionInfo checks whether the
2085 // debugger is active. 2085 // debugger is active.
2086 MaybeHandle<Code> maybe_result = target_function.is_null() 2086 MaybeHandle<Code> maybe_result = target_function.is_null()
2087 ? Compiler::GetUnoptimizedCode(target) 2087 ? Compiler::GetUnoptimizedCode(target)
2088 : Compiler::GetUnoptimizedCode(target_function); 2088 : Compiler::GetUnoptimizedCode(target_function);
2089 if (maybe_result.is_null()) return isolate_->factory()->undefined_value(); 2089 if (maybe_result.is_null()) return isolate_->factory()->undefined_value();
2090 } 2090 }
2091 } // End while loop. 2091 } // End while loop.
2092 2092
2093 // JSFunctions from the same literal may not have the same shared function 2093 // JSFunctions from the same literal may not have the same shared function
2094 // info. Find those JSFunctions and deduplicate the shared function info. 2094 // info. Find those JSFunctions and deduplicate the shared function info.
(...skipping 1294 matching lines...) Expand 10 before | Expand all | Expand 10 after
3389 } 3389 }
3390 3390
3391 3391
3392 void LockingCommandMessageQueue::Clear() { 3392 void LockingCommandMessageQueue::Clear() {
3393 base::LockGuard<base::Mutex> lock_guard(&mutex_); 3393 base::LockGuard<base::Mutex> lock_guard(&mutex_);
3394 queue_.Clear(); 3394 queue_.Clear();
3395 } 3395 }
3396 3396
3397 } // namespace internal 3397 } // namespace internal
3398 } // namespace v8 3398 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698