Update libxml gyp and BUILD.gn, was missing some .h files

Update libxml gyp and BUILD.gn, was missing some .h files

This caused the analyze step to be too aggressive in skipping things
which caused https://codereview.chromium.org/1204813002 to land and
break many compiles.

(Case-insensitive sort order preserved to make it clear what changes
in this CL, I'll do a separate no-op that sorts the list properly.)

BUG=463958, 502468, 503747
Committed: https://crrev.com/127d99b4c173af397cb46ee089c80630adfb5a14
Cr-Commit-Position: refs/heads/master@{#335822}

[scottmg, 2015-06-23 21:12:20]

scottmg@chromium.org changed reviewers:
+ thakis@chromium.org

[scottmg, 2015-06-23 21:17:23]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-23 21:17:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1207543002/60001

[scottmg, 2015-06-23 21:27:19]

oops, forgot GN, one sec.

[Nico, 2015-06-23 21:30:20]

https://codereview.chromium.org/1207543002/diff/60001/third_party/libxml/libx...
File third_party/libxml/libxml.gyp (right):

https://codereview.chromium.org/1207543002/diff/60001/third_party/libxml/libx...
third_party/libxml/libxml.gyp:177: 'src/xmlIO.c',
xmlIO.h includes xzlib.h, so maybe add that too?

[scottmg, 2015-06-23 21:32:43]

https://codereview.chromium.org/1207543002/diff/60001/third_party/libxml/libx...
File third_party/libxml/libxml.gyp (right):

https://codereview.chromium.org/1207543002/diff/60001/third_party/libxml/libx...
third_party/libxml/libxml.gyp:177: 'src/xmlIO.c',
On 2015/06/23 21:30:20, Nico wrote:
> xmlIO.h includes xzlib.h, so maybe add that too?

[clang-win2]d:\src\cr3\src\third_party\libxml>pt HAVE_LZMA
linux\config.h:110:/* #undef HAVE_LZMA_H */
mac\config.h:110:/* #undef HAVE_LZMA_H */

so I'm not sure if it's more or less confusing to have it? (We don't want
xzlib.c in any case)

[scottmg, 2015-06-23 21:35:17]

On 2015/06/23 21:32:43, scottmg wrote:
>
https://codereview.chromium.org/1207543002/diff/60001/third_party/libxml/libx...
> File third_party/libxml/libxml.gyp (right):
> 
>
https://codereview.chromium.org/1207543002/diff/60001/third_party/libxml/libx...
> third_party/libxml/libxml.gyp:177: 'src/xmlIO.c',
> On 2015/06/23 21:30:20, Nico wrote:
> > xmlIO.h includes xzlib.h, so maybe add that too?
> 
> [clang-win2]d:\src\cr3\src\third_party\libxml>pt HAVE_LZMA
> linux\config.h:110:/* #undef HAVE_LZMA_H */
> mac\config.h:110:/* #undef HAVE_LZMA_H */
> 
> so I'm not sure if it's more or less confusing to have it? (We don't want
> xzlib.c in any case)

I guess I'll put them in comments like the others that exist but are omitted.

[scottmg, 2015-06-23 21:37:22]

OK! BEST CL EVER PTAL

[Nico, 2015-06-23 21:38:38]

BEST LGTM

[scottmg, 2015-06-23 21:56:48]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2015-06-23 22:00:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1207543002/80001

[commit-bot: I haz the power, 2015-06-23 22:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 22:14:08]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Nico, 2015-06-23 22:15:59]

"ninja: error: '../../third_party/libxml/src/timsort.c', needed by
'obj/third_party/libxml/src/libxml2.timsort.o', missing and no known rule
to make it"

…wot?

On Tue, Jun 23, 2015 at 3:14 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Try jobs failed on following builders:
>   android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
>
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...
> )
>
> https://codereview.chromium.org/1207543002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2015-06-23 22:16:25]

https://codereview.chromium.org/1207543002/diff/80001/third_party/libxml/BUIL...
File third_party/libxml/BUILD.gn (right):

https://codereview.chromium.org/1207543002/diff/80001/third_party/libxml/BUIL...
third_party/libxml/BUILD.gn:111: "src/timsort.c",
oh, this should say .h

[scottmg, 2015-06-23 22:27:21]

https://codereview.chromium.org/1207543002/diff/80001/third_party/libxml/BUIL...
File third_party/libxml/BUILD.gn (right):

https://codereview.chromium.org/1207543002/diff/80001/third_party/libxml/BUIL...
third_party/libxml/BUILD.gn:111: "src/timsort.c",
On 2015/06/23 22:16:25, Nico wrote:
> oh, this should say .h

darn, maybe not best cl ever

[scottmg, 2015-06-23 22:28:00]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2015-06-23 22:28:00]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1207543002/#ps100001
(title: "timsort.h")

[commit-bot: I haz the power, 2015-06-23 22:29:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1207543002/100001

[commit-bot: I haz the power, 2015-06-24 00:16:20]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-06-24 00:17:16]

Patchset 6 (id:??) landed as
https://crrev.com/127d99b4c173af397cb46ee089c80630adfb5a14
Cr-Commit-Position: refs/heads/master@{#335822}