Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1204813002: Fix incorrect libxml fprintf, erroring on clang win x64 (Closed)

Created:
5 years, 6 months ago by scottmg
Modified:
5 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect libxml fprintf, erroring on clang win x64 R=thakis@chromium.org BUG=https://bugzilla.gnome.org/show_bug.cgi?id=751410 BUG=82385 Committed: https://crrev.com/73a2484753cd6b2e4af673cd6dc752ba5b00c116 Cr-Commit-Position: refs/heads/master@{#335736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/libxml/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libxml/src/timsort.h View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
scottmg
5 years, 6 months ago (2015-06-23 20:25:12 UTC) #1
Nico
lgtm, thanks!
5 years, 6 months ago (2015-06-23 20:26:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204813002/1
5 years, 6 months ago (2015-06-23 20:28:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 20:37:17 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/73a2484753cd6b2e4af673cd6dc752ba5b00c116 Cr-Commit-Position: refs/heads/master@{#335736}
5 years, 6 months ago (2015-06-23 20:39:25 UTC) #6
scottmg
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1202303002/ by scottmg@chromium.org. ...
5 years, 6 months ago (2015-06-23 20:47:28 UTC) #7
Stephen Chennney
5 years, 6 months ago (2015-06-23 20:56:52 UTC) #8
Message was sent while issue was closed.
On 2015/06/23 20:47:28, scottmg wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1202303002/ by mailto:scottmg@chromium.org.
> 
> The reason for reverting is: Broke cast android whatever that is.
>
http://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%2....

Broke the world, in fact.

Powered by Google App Engine
This is Rietveld 408576698