Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: Source/modules/vr/HMDVRDevice.cpp

Issue 1207513003: Some name casing corrections suggested by esprehn@ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/vr/HMDVRDevice.h ('k') | Source/modules/vr/VRPositionState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/vr/HMDVRDevice.cpp
diff --git a/Source/modules/vr/HMDVRDevice.cpp b/Source/modules/vr/HMDVRDevice.cpp
index 76d12978ce6571c13a34788e2028ae4117f0ae16..55a14a8d399a56eac23ef91801a38b82ced06f9b 100644
--- a/Source/modules/vr/HMDVRDevice.cpp
+++ b/Source/modules/vr/HMDVRDevice.cpp
@@ -11,14 +11,9 @@
namespace blink {
-HMDVRDevice::HMDVRDevice(VRHardwareUnit* hardwareUnit, unsigned deviceId)
- : VRDevice(hardwareUnit, deviceId)
-{
- m_eyeParametersLeft = VREyeParameters::create();
- m_eyeParametersRight = VREyeParameters::create();
-}
+namespace {
-VREye HMDVRDevice::StringToVREye(const String& whichEye)
+VREye stringToVREye(const String& whichEye)
{
if (whichEye == "left")
return VREyeLeft;
@@ -27,6 +22,15 @@ VREye HMDVRDevice::StringToVREye(const String& whichEye)
return VREyeNone;
}
+} // namepspace
+
+HMDVRDevice::HMDVRDevice(VRHardwareUnit* hardwareUnit, unsigned deviceId)
+ : VRDevice(hardwareUnit, deviceId)
+{
+ m_eyeParametersLeft = VREyeParameters::create();
+ m_eyeParametersRight = VREyeParameters::create();
+}
+
void HMDVRDevice::updateFromWebVRDevice(const WebVRDevice& device)
{
VRDevice::updateFromWebVRDevice(device);
@@ -38,7 +42,7 @@ void HMDVRDevice::updateFromWebVRDevice(const WebVRDevice& device)
VREyeParameters* HMDVRDevice::getEyeParameters(const String& whichEye)
{
- switch (StringToVREye(whichEye)) {
+ switch (stringToVREye(whichEye)) {
case VREyeLeft:
return m_eyeParametersLeft;
case VREyeRight:
« no previous file with comments | « Source/modules/vr/HMDVRDevice.h ('k') | Source/modules/vr/VRPositionState.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698