Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1207483006: Sync: Report unmatched unassociated node during optimistic bookmark association. (Closed)

Created:
5 years, 6 months ago by stanisc
Modified:
5 years, 5 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync Report unmatched unassociated node during optimistic bookmark association. This will verify an assumption that all sync nodes must be already associated and have external IDs during optimistic association. Running into a node with unassigned external ID would indicate an issue with the delayed PersistAssociations task. BUG=456876 Committed: https://crrev.com/2ef675dbcd5943aad03184b67696330cc910568d Cr-Commit-Position: refs/heads/master@{#335998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/sync/glue/bookmark_model_associator.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
stanisc
PTAL!
5 years, 6 months ago (2015-06-23 22:47:11 UTC) #2
Nicolas Zea
lgtm
5 years, 5 months ago (2015-06-24 19:51:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1207483006/1
5 years, 5 months ago (2015-06-24 20:47:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-24 20:53:49 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-24 20:54:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ef675dbcd5943aad03184b67696330cc910568d
Cr-Commit-Position: refs/heads/master@{#335998}

Powered by Google App Engine
This is Rietveld 408576698