Sync: Report unmatched unassociated node during optimistic bookmark association.

chrome/browser/sync/glue/bookmark_model_associator.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/bookmark_model_associator.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/containers/hash_tables.h"
 #include "base/format_macros.h"
@@ skipping 845 matching lines @@
           // There is another matching node which means the local node
           // has been either moved or edited.
           // In this case assume the local model to be correct, delete the
           // sync node, and let the matching node to be propagated to Sync.
           // TODO(stanisc): crbug/456876: this should really be handled with
           // a move, but the move depends on the traversal order.
           int num = RemoveSyncNodeHierarchy(trans, sync_child_node.GetId());
           context->IncrementSyncItemsDeleted(num);
           continue;
         }
+      } else {
+        // Existing sync node isn't associated. This is unexpected during
+        // optimistic association unless there the previous association failed
+        // to
+        // persist extern IDs (that might be the case because persisting
+        // external
+        // IDs is delayed).
+        // Report this error only once per session.
+        static bool g_unmatched_unassociated_node_reported = false;
+        if (!g_unmatched_unassociated_node_reported) {
+          g_unmatched_unassociated_node_reported = true;
+          unrecoverable_error_handler_->CreateAndUploadError(
+              FROM_HERE,
+              "Unassociated sync node detected during optimistic association",
+              model_type());
+        }
       }
 
       syncer::SyncError error;
       child_node = CreateBookmarkNode(parent_node, index, &sync_child_node, url,
                                       context, &error);
       if (!child_node) {
         if (error.IsSet()) {
           return error;
         } else {
           // Skip this node and continue. Don't increment index in this case.
@@ skipping 297 matching lines @@
                                  syncer::BOOKMARKS);
       } else {
         context->set_native_model_sync_state(BEHIND);
       }
     }
   }
   return syncer::SyncError();
 }
 
 }  // namespace browser_sync