Allow cert-popup for WebView guests.

chrome/browser/ui/views/profiles/profile_chooser_view.cc

Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
index d1945be97a86dc5fc214a8f77426e6823344af9e..686cebbd5effdff2c194bdf71e9006d9f2355697 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
@@ -1537,6 +1537,15 @@ views::View* ProfileChooserView::CreateGaiaSigninView(
   views::WebView* web_view = new views::WebView(profile);
   web_view->LoadInitialURL(url);
   web_view->GetWebContents()->SetDelegate(this);
+
+  // TODO(davidben): When crbug.com/456255 is resolved, presumably we won't
+  // need a popup manager and the following code can be removed.
+  // It probably makes more sense for a cert-selection dialog in the signin
+  // bubble to be browser-modal, and not bubble-modal.

[Ryan Sleevi, 2015/07/07 12:27:19]

I'm not sure what you mean by browser-modal here - but it was intentional that
it was tab-modal as part of the excision of browser-modal dialogs. That's why
the URLRequest surfaces up the renderer IDs, and we coalesce to a single prompt
across multiple tabs (or more aptly, we spawn a tab modal dialog for each tab
that is blocked on this auth flow, and when the user responds in any one tab, it
dismisses the other tabs dialogs)

+  if (!popup_manager_)
+    popup_manager_.reset(new web_modal::PopupManager(nullptr));
+  popup_manager_->RegisterWith(web_view->GetWebContents());
+
   web_view->SetPreferredSize(
       gfx::Size(kFixedGaiaViewWidth, kFixedGaiaViewHeight));
   content::RenderWidgetHostView* rwhv =