Allow cert-popup for WebView guests.

chrome/browser/ui/views/profiles/profile_chooser_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/profiles/profile_chooser_view.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
@@ skipping 1519 matching lines @@
     default:
       NOTREACHED() << "Called with invalid mode=" << view_mode_;
       return NULL;
   }
 
   // Adds Gaia signin webview
   Profile* profile = browser_->profile();
   views::WebView* web_view = new views::WebView(profile);
   web_view->LoadInitialURL(url);
   web_view->GetWebContents()->SetDelegate(this);
+
+  // TODO(davidben): When crbug.com/456255 is resolved, presumably we won't
+  // need a popup manager and the following code can be removed.
+  // It probably makes more sense for a cert-selection dialog in the signin
+  // bubble to be browser-modal, and not bubble-modal.

[Ryan Sleevi, 2015/07/07 12:27:19]

I'm not sure what you mean by browser-modal here - but it was intentional that
it was tab-modal as part of the excision of browser-modal dialogs. That's why
the URLRequest surfaces up the renderer IDs, and we coalesce to a single prompt
across multiple tabs (or more aptly, we spawn a tab modal dialog for each tab
that is blocked on this auth flow, and when the user responds in any one tab, it
dismisses the other tabs dialogs)

+  if (!popup_manager_)
+    popup_manager_.reset(new web_modal::PopupManager(nullptr));
+  popup_manager_->RegisterWith(web_view->GetWebContents());
+
   web_view->SetPreferredSize(
       gfx::Size(kFixedGaiaViewWidth, kFixedGaiaViewHeight));
   content::RenderWidgetHostView* rwhv =
       web_view->GetWebContents()->GetRenderWidgetHostView();
   if (rwhv)
     rwhv->SetBackgroundColor(profiles::kAvatarBubbleGaiaBackgroundColor);
   TitleCard* title_card = new TitleCard(l10n_util::GetStringUTF16(message_id),
                                         this,
                                         &gaia_signin_cancel_button_);
   if (signin_content_view)
@@ skipping 197 matching lines @@
       IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
           IncognitoModePrefs::DISABLED;
   return incognito_available && !browser_->profile()->IsGuestSession();
 }
 
 void ProfileChooserView::PostActionPerformed(
     ProfileMetrics::ProfileDesktopMenu action_performed) {
   ProfileMetrics::LogProfileDesktopMenu(action_performed, gaia_service_type_);
   gaia_service_type_ = signin::GAIA_SERVICE_TYPE_NONE;
 }