Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 120683005: content: Copy AHEM font to its final destination path. (Closed)

Created:
6 years, 11 months ago by tfarina
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

content: Migrate everything from TestRunner_resources over content_shell. This copies the necessary fonts and add the necessary dependencies to get rid of blink_test_runner.gyp dep. BUG=331303 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244052

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : add missing comma in mac condition #

Patch Set 4 : add more missing commas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1 line) Patch
M content/content_shell.gypi View 1 2 3 4 chunks +51 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
6 years, 11 months ago (2014-01-05 20:09:10 UTC) #1
jochen (gone - plz use gerrit)
won't this collide with the copy rule from blink? Can you make an atomic commit ...
6 years, 11 months ago (2014-01-07 10:26:11 UTC) #2
tfarina
On 2014/01/07 10:26:11, jochen wrote: > won't this collide with the copy rule from blink? ...
6 years, 11 months ago (2014-01-07 18:39:34 UTC) #3
jochen (gone - plz use gerrit)
On 2014/01/07 18:39:34, tfarina wrote: > On 2014/01/07 10:26:11, jochen wrote: > > won't this ...
6 years, 11 months ago (2014-01-08 09:57:19 UTC) #4
tfarina
Jochen, I added all the missing pieces. Please, could you take another look? Thanks!
6 years, 11 months ago (2014-01-09 22:37:24 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-09 22:39:16 UTC) #6
tfarina
Right after this lands, we will have to remove TestRunner_resources from third_party/WebKit/public/all.gyp so the "multiple ...
6 years, 11 months ago (2014-01-09 23:05:42 UTC) #7
tfarina
I have uploaded https://codereview.chromium.org/132663004 to track the Blink side.
6 years, 11 months ago (2014-01-09 23:11:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/120683005/210001
6 years, 11 months ago (2014-01-09 23:21:27 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=111370
6 years, 11 months ago (2014-01-10 01:05:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/120683005/210001
6 years, 11 months ago (2014-01-10 01:23:39 UTC) #11
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 02:34:56 UTC) #12
Message was sent while issue was closed.
Change committed as 244052

Powered by Google App Engine
This is Rietveld 408576698