Issue 132663004: Remove TestRunner_resources target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132663004: Remove TestRunner_resources target. (Closed)

Created:
6 years, 11 months ago by tfarina

Modified:
6 years, 11 months ago

Reviewers:
jochen (gone - plz use gerrit), abarth-chromium

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Remove TestRunner_resources target. After https://codereview.chromium.org/120683005/, TestRunner_resources will not be used anymore and thus can be removed from Blink. We also need to remove it, at least from all.gyp, to avoid the "multiple rules" warning on ninja. BUG=331303 TEST=None R=jochen@chromium.org,abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164850

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -72 lines)			Patch
M	Source/testing/testing.gyp	View	1 chunk	+0 lines, -61 lines	0 comments	Download
M	public/all.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	public/blink_test_runner.gyp	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

tfarina

This have to wait until https://codereview.chromium.org/120683005/ lands.

6 years, 11 months ago (2014-01-09 23:11:36 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/132663004/1

6 years, 11 months ago (2014-01-10 05:49:01 UTC) #3

Message was sent while issue was closed.

Change committed as 164850