Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1206803003: Remove overzealous checking of --cache-optimized-code flag. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_opt-code-map-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove overzealous checking of --cache-optimized-code flag. R=bmeurer@chromium.org Committed: https://crrev.com/8f6bca542f11bfcbae1761ab39c27c04b3e57e53 Cr-Commit-Position: refs/heads/master@{#29284}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -29 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M src/compiler.cc View 1 chunk +10 lines, -12 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +1 line, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-24 13:56:20 UTC) #1
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-25 04:08:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206803003/1
5 years, 6 months ago (2015-06-25 04:08:26 UTC) #4
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-25 04:09:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206803003/20001
5 years, 6 months ago (2015-06-25 09:43:37 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-25 09:45:03 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 09:45:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f6bca542f11bfcbae1761ab39c27c04b3e57e53
Cr-Commit-Position: refs/heads/master@{#29284}

Powered by Google App Engine
This is Rietveld 408576698