getComputedStyle(e).quotes always return empty string

Source/core/css/ComputedStyleCSSValueMapping.cpp

Index: Source/core/css/ComputedStyleCSSValueMapping.cpp
diff --git a/Source/core/css/ComputedStyleCSSValueMapping.cpp b/Source/core/css/ComputedStyleCSSValueMapping.cpp
index 4c8e0e406815643bab17c6902817f83b2cf36407..b7f53c6ae9da616905808eeb9244d33014fd66f9 100644
--- a/Source/core/css/ComputedStyleCSSValueMapping.cpp
+++ b/Source/core/css/ComputedStyleCSSValueMapping.cpp
@@ -50,6 +50,7 @@
 #include "core/style/ContentData.h"
 #include "core/style/ComputedStyle.h"
 #include "core/style/PathStyleMotionPath.h"
+#include "core/style/QuotesData.h"
 #include "core/style/ShadowList.h"
 #include "platform/LengthFunctions.h"
 
@@ -1911,6 +1912,18 @@ PassRefPtrWillBeRawPtr<CSSValue> ComputedStyleCSSValueMapping::get(CSSPropertyID
     }
     case CSSPropertyPosition:
         return cssValuePool().createValue(style.position());
+    case CSSPropertyQuotes:
+        if (!style.quotes())
+            return nullptr;

[Timothy Loh, 2015/06/29 05:27:58]

We shouldn't be returning nullptr from here, can we at least have a TODO to fix
this?

[ramya.v, 2015/06/29 05:47:10]

For this case, IE behavior is returning null, empty output.
Firefox behavior is returning default quotes value "“" "”" "‘" "’".
Do we need to match with firefox behavior here?

[Timothy Loh, 2015/06/29 05:52:37]

It looks like we use different quotes depending on language (see
LayoutQuote.cpp), so we probably should be returning the quotes values that
we're actually using.

[ramya.v, 2015/06/29 06:04:06]

Done.

+        if (style.quotes()->size()) {
+            RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
+            for (int i = 0; i < style.quotes()->size(); i++) {
+                list->append(cssValuePool().createValue(style.quotes()->getOpenQuote(i), CSSPrimitiveValue::CSS_STRING));
+                list->append(cssValuePool().createValue(style.quotes()->getCloseQuote(i), CSSPrimitiveValue::CSS_STRING));
+            }
+            return list.release();
+        }
+        return cssValuePool().createIdentifierValue(CSSValueNone);
     case CSSPropertyRight:
         return valueForPositionOffset(style, CSSPropertyRight, layoutObject);
     case CSSPropertyWebkitRubyPosition:
@@ -2482,7 +2495,6 @@ PassRefPtrWillBeRawPtr<CSSValue> ComputedStyleCSSValueMapping::get(CSSPropertyID
 
     // Other unimplemented properties.
     case CSSPropertyPage: // for @page
-    case CSSPropertyQuotes: // FIXME: needs implementation
     case CSSPropertySize: // for @page
         return nullptr;