getComputedStyle(e).quotes always return empty string

Source/core/css/ComputedStyleCSSValueMapping.cpp

 /*
  * Copyright (C) 2004 Zack Rusin <zack@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2011 Sencha, Inc. All rights reserved.
  * Copyright (C) 2015 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ skipping 32 matching lines @@
 #include "core/css/Counter.h"
 #include "core/css/Pair.h"
 #include "core/css/Rect.h"
 #include "core/layout/LayoutBlock.h"
 #include "core/layout/LayoutBox.h"
 #include "core/layout/LayoutGrid.h"
 #include "core/layout/LayoutObject.h"
 #include "core/style/ContentData.h"
 #include "core/style/ComputedStyle.h"
 #include "core/style/PathStyleMotionPath.h"
+#include "core/style/QuotesData.h"
 #include "core/style/ShadowList.h"
 #include "platform/LengthFunctions.h"
 
 namespace blink {
 
 inline static bool isFlexOrGrid(Node* element)
 {
     return element && element->ensureComputedStyle()
         && element->ensureComputedStyle()->isDisplayFlexibleOrGridBox();
 }
@@ skipping 1841 matching lines @@
         return cssValuePool().createValue(style.pageBreakBefore());
     case CSSPropertyPageBreakInside: {
         EPageBreak pageBreak = style.pageBreakInside();
         ASSERT(pageBreak != PBALWAYS);
         if (pageBreak == PBALWAYS)
             return nullptr;
         return cssValuePool().createValue(style.pageBreakInside());
     }
     case CSSPropertyPosition:
         return cssValuePool().createValue(style.position());
+    case CSSPropertyQuotes:
+        if (!style.quotes())
+            return nullptr;

[Timothy Loh, 2015/06/29 05:27:58]

We shouldn't be returning nullptr from here, can we at least have a TODO to fix
this?

[ramya.v, 2015/06/29 05:47:10]

For this case, IE behavior is returning null, empty output.
Firefox behavior is returning default quotes value "“" "”" "‘" "’".
Do we need to match with firefox behavior here?

[Timothy Loh, 2015/06/29 05:52:37]

It looks like we use different quotes depending on language (see
LayoutQuote.cpp), so we probably should be returning the quotes values that
we're actually using.

[ramya.v, 2015/06/29 06:04:06]

Done.

+        if (style.quotes()->size()) {
+            RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
+            for (int i = 0; i < style.quotes()->size(); i++) {
+                list->append(cssValuePool().createValue(style.quotes()->getOpenQuote(i), CSSPrimitiveValue::CSS_STRING));
+                list->append(cssValuePool().createValue(style.quotes()->getCloseQuote(i), CSSPrimitiveValue::CSS_STRING));
+            }
+            return list.release();
+        }
+        return cssValuePool().createIdentifierValue(CSSValueNone);
     case CSSPropertyRight:
         return valueForPositionOffset(style, CSSPropertyRight, layoutObject);
     case CSSPropertyWebkitRubyPosition:
         return cssValuePool().createValue(style.rubyPosition());
     case CSSPropertyScrollBehavior:
         return cssValuePool().createValue(style.scrollBehavior());
     case CSSPropertyScrollBlocksOn:
         return scrollBlocksOnFlagsToCSSValue(style.scrollBlocksOn());
     case CSSPropertyTableLayout:
         return cssValuePool().createValue(style.tableLayout());
@@ skipping 551 matching lines @@
         ASSERT_NOT_REACHED();
         return nullptr;
 
     // Unimplemented @font-face properties.
     case CSSPropertySrc:
     case CSSPropertyUnicodeRange:
         return nullptr;
 
     // Other unimplemented properties.
     case CSSPropertyPage: // for @page
-    case CSSPropertyQuotes: // FIXME: needs implementation
     case CSSPropertySize: // for @page
         return nullptr;
 
     // Unimplemented -webkit- properties.
     case CSSPropertyWebkitMarginCollapse:
     case CSSPropertyWebkitMask:
     case CSSPropertyWebkitMaskRepeatX:
     case CSSPropertyWebkitMaskRepeatY:
     case CSSPropertyWebkitPerspectiveOriginX:
     case CSSPropertyWebkitPerspectiveOriginY:
@@ skipping 195 matching lines @@
     case CSSPropertyAll:
         return nullptr;
     default:
         break;
     }
     ASSERT_NOT_REACHED();
     return nullptr;
 }
 
 }