getComputedStyle(e).quotes always return empty string

getComputedStyle(e).quotes always return empty string

Implement getComputedStyle(e).quotes

BUG=472963
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197978

[ramya.v, 2015-06-24 11:22:06]

ramya.v@samsung.com changed reviewers:
+ esprehn@chromium.org, sashab@chromium.org, timloh@chromium.org

[ramya.v, 2015-06-24 11:22:07]

PTAL!

This patch gives output similar to Firefox in case of 
""" """ --> "\"" "\"" since we are taking primitive value CSS_STRING while
constructing CSSValueList. Please let me know if we can avoid escaping of double
quote.


Thanks

[ramya.v, 2015-06-28 13:11:54]

On 2015/06/24 11:22:07, ramya.v wrote:
> PTAL!
> 
> This patch gives output similar to Firefox in case of 
> """ """ --> "\"" "\"" since we are taking primitive value CSS_STRING while
> constructing CSSValueList. Please let me know if we can avoid escaping of
double
> quote.
> 
> 
> Thanks

Friendly ping..
PTAL!

Thanks

[Timothy Loh, 2015-06-29 05:27:59]

lgtm

https://codereview.chromium.org/1206793002/diff/1/Source/core/css/ComputedSty...
File Source/core/css/ComputedStyleCSSValueMapping.cpp (right):

https://codereview.chromium.org/1206793002/diff/1/Source/core/css/ComputedSty...
Source/core/css/ComputedStyleCSSValueMapping.cpp:1917: return nullptr;
We shouldn't be returning nullptr from here, can we at least have a TODO to fix
this?

https://codereview.chromium.org/1206793002/diff/1/Source/core/style/QuotesData.h
File Source/core/style/QuotesData.h (right):

https://codereview.chromium.org/1206793002/diff/1/Source/core/style/QuotesDat...
Source/core/style/QuotesData.h:44: int size() { return m_quotePairs.size();}
missing space between ; and }

[ramya.v, 2015-06-29 05:47:11]

https://codereview.chromium.org/1206793002/diff/1/Source/core/css/ComputedSty...
File Source/core/css/ComputedStyleCSSValueMapping.cpp (right):

https://codereview.chromium.org/1206793002/diff/1/Source/core/css/ComputedSty...
Source/core/css/ComputedStyleCSSValueMapping.cpp:1917: return nullptr;
On 2015/06/29 05:27:58, Timothy Loh wrote:
> We shouldn't be returning nullptr from here, can we at least have a TODO to
fix
> this?


For this case, IE behavior is returning null, empty output.
Firefox behavior is returning default quotes value "“" "”" "‘" "’".
Do we need to match with firefox behavior here?

[Timothy Loh, 2015-06-29 05:52:37]

https://codereview.chromium.org/1206793002/diff/1/Source/core/css/ComputedSty...
File Source/core/css/ComputedStyleCSSValueMapping.cpp (right):

https://codereview.chromium.org/1206793002/diff/1/Source/core/css/ComputedSty...
Source/core/css/ComputedStyleCSSValueMapping.cpp:1917: return nullptr;
On 2015/06/29 05:47:10, ramya.v wrote:
> On 2015/06/29 05:27:58, Timothy Loh wrote:
> > We shouldn't be returning nullptr from here, can we at least have a TODO to
> fix
> > this?
> 
> 
> For this case, IE behavior is returning null, empty output.
> Firefox behavior is returning default quotes value "“" "”" "‘" "’".
> Do we need to match with firefox behavior here?

It looks like we use different quotes depending on language (see
LayoutQuote.cpp), so we probably should be returning the quotes values that
we're actually using.

[ramya.v, 2015-06-29 06:04:06]

Updated as per review comments. PTAL!

Thanks

https://codereview.chromium.org/1206793002/diff/1/Source/core/css/ComputedSty...
File Source/core/css/ComputedStyleCSSValueMapping.cpp (right):

https://codereview.chromium.org/1206793002/diff/1/Source/core/css/ComputedSty...
Source/core/css/ComputedStyleCSSValueMapping.cpp:1917: return nullptr;
On 2015/06/29 05:52:37, Timothy Loh wrote:
> On 2015/06/29 05:47:10, ramya.v wrote:
> > On 2015/06/29 05:27:58, Timothy Loh wrote:
> > > We shouldn't be returning nullptr from here, can we at least have a TODO
to
> > fix
> > > this?
> > 
> > 
> > For this case, IE behavior is returning null, empty output.
> > Firefox behavior is returning default quotes value "“" "”" "‘" "’".
> > Do we need to match with firefox behavior here?
> 
> It looks like we use different quotes depending on language (see
> LayoutQuote.cpp), so we probably should be returning the quotes values that
> we're actually using.

Done.

https://codereview.chromium.org/1206793002/diff/1/Source/core/style/QuotesData.h
File Source/core/style/QuotesData.h (right):

https://codereview.chromium.org/1206793002/diff/1/Source/core/style/QuotesDat...
Source/core/style/QuotesData.h:44: int size() { return m_quotePairs.size();}
On 2015/06/29 05:27:58, Timothy Loh wrote:
> missing space between ; and }

Done.

[ramya.v, 2015-06-29 09:04:30]

The CQ bit was checked by ramya.v@samsung.com

[ramya.v, 2015-06-29 09:04:30]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1206793002/#ps20001
(title: "Updating as per review comments")

[commit-bot: I haz the power, 2015-06-29 09:04:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1206793002/20001

[commit-bot: I haz the power, 2015-06-29 11:31:16]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197978