Function Layout, Global Variable Layout and Pooled Constants Layout Reordering

src/IceClFlags.h

Index: src/IceClFlags.h
diff --git a/src/IceClFlags.h b/src/IceClFlags.h
index 3b9b0067601d54600902de4ca5dead4be7fa563d..cc743353351a45224cae9c171519682a69f16d29 100644
--- a/src/IceClFlags.h
+++ b/src/IceClFlags.h
@@ -139,7 +139,6 @@ public:
   setRandomizeAndPoolImmediatesOption(RandomizeAndPoolImmediatesEnum Option) {
     RandomizeAndPoolImmediatesOption = Option;
   }
-
   RandomizeAndPoolImmediatesEnum getRandomizeAndPoolImmediatesOption() const {
     return RandomizeAndPoolImmediatesOption;
   }
@@ -151,6 +150,26 @@ public:
     return RandomizeAndPoolImmediatesThreshold;
   }
 
+  void setShouldReorderFunctions(bool Option) { ReorderFunctions = Option; }
+  bool shouldReorderFunctions() const { return ReorderFunctions; }
+
+  void setReorderFunctionsWindowSize(uint32_t Size) {
+    ReorderFunctionsWindowSize = Size;
+  }
+  uint32_t getReorderFunctionsWindowSize() const {
+    return ReorderFunctionsWindowSize;
+  }
+
+  void setShouldReorderGlobalVariables(bool Option) {
+    ReorderGlobalVariables = Option;
+  }
+  bool shouldReorderGlobalVariables() const { return ReorderGlobalVariables; }
+
+  void setShouldReorderPooledConstants(bool Option) {
+    ReorderPooledConstants = Option;
+  }
+  bool shouldReorderPooledConstants() const { return ReorderPooledConstants; }
+
   // IceString accessors.
 
   const IceString &getDefaultFunctionPrefix() const {
@@ -231,6 +250,16 @@ private:
   RandomizeAndPoolImmediatesEnum RandomizeAndPoolImmediatesOption;
   uint32_t RandomizeAndPoolImmediatesThreshold;
 
+  // Function reordering options
+  bool ReorderFunctions;

[jvoung (off chromium), 2015/06/24 17:36:37]

We had previously grouped all of the "bool" options together, and all of the
int-like options together (e.g., RandomNopInsertion vs
RandomNopProbabilityAsPercentage)... I think for alignment / padding efficiency.
At least with types like uint64_t which have wider alignment, we wouldn't want
to interleave bool and uint64_t (not the case here, but an example of why)
because it introduces padding.

Yes there is some akwardness in that the ReorderFunctions will be separate from
ReorderFunctionsWindowSize though...

[qining, 2015/06/24 20:18:55]

Done.

+  uint32_t ReorderFunctionsWindowSize;
+
+  // Global variable reordering option
+  bool ReorderGlobalVariables;
+
+  // Pooled constant reordering option
+  bool ReorderPooledConstants;
+
   size_t NumTranslationThreads; // 0 means completely sequential
   uint64_t RandomSeed;
 };