Function Layout, Global Variable Layout and Pooled Constants Layout Reordering

src/IceClFlags.h

 //===- subzero/src/IceClFlags.h - Cl Flags for translation ------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file declares command line flags controlling translation.
@@ skipping 121 matching lines @@
 
   VerboseMask getVerbose() const {
     return ALLOW_DUMP ? VMask : (VerboseMask)IceV_None;
   }
   void setVerbose(VerboseMask NewValue) { VMask = NewValue; }
 
   void
   setRandomizeAndPoolImmediatesOption(RandomizeAndPoolImmediatesEnum Option) {
     RandomizeAndPoolImmediatesOption = Option;
   }
-
   RandomizeAndPoolImmediatesEnum getRandomizeAndPoolImmediatesOption() const {
     return RandomizeAndPoolImmediatesOption;
   }
 
   void setRandomizeAndPoolImmediatesThreshold(uint32_t Threshold) {
     RandomizeAndPoolImmediatesThreshold = Threshold;
   }
   uint32_t getRandomizeAndPoolImmediatesThreshold() const {
     return RandomizeAndPoolImmediatesThreshold;
   }
 
+  void setShouldReorderFunctions(bool Option) { ReorderFunctions = Option; }
+  bool shouldReorderFunctions() const { return ReorderFunctions; }
+
+  void setReorderFunctionsWindowSize(uint32_t Size) {
+    ReorderFunctionsWindowSize = Size;
+  }
+  uint32_t getReorderFunctionsWindowSize() const {
+    return ReorderFunctionsWindowSize;
+  }
+
+  void setShouldReorderGlobalVariables(bool Option) {
+    ReorderGlobalVariables = Option;
+  }
+  bool shouldReorderGlobalVariables() const { return ReorderGlobalVariables; }
+
+  void setShouldReorderPooledConstants(bool Option) {
+    ReorderPooledConstants = Option;
+  }
+  bool shouldReorderPooledConstants() const { return ReorderPooledConstants; }
+
   // IceString accessors.
 
   const IceString &getDefaultFunctionPrefix() const {
     return DefaultFunctionPrefix;
   }
   void setDefaultFunctionPrefix(const IceString &NewValue) {
     DefaultFunctionPrefix = NewValue;
   }
 
   const IceString &getDefaultGlobalPrefix() const {
@@ skipping 60 matching lines @@
   IceString DefaultGlobalPrefix;
   IceString TestPrefix;
   IceString TimingFocusOn;
   IceString TranslateOnly;
   IceString VerboseFocusOn;
 
   // Immediates Randomization and Pooling options
   RandomizeAndPoolImmediatesEnum RandomizeAndPoolImmediatesOption;
   uint32_t RandomizeAndPoolImmediatesThreshold;
 
+  // Function reordering options
+  bool ReorderFunctions;

[jvoung (off chromium), 2015/06/24 17:36:37]

We had previously grouped all of the "bool" options together, and all of the
int-like options together (e.g., RandomNopInsertion vs
RandomNopProbabilityAsPercentage)... I think for alignment / padding efficiency.
At least with types like uint64_t which have wider alignment, we wouldn't want
to interleave bool and uint64_t (not the case here, but an example of why)
because it introduces padding.

Yes there is some akwardness in that the ReorderFunctions will be separate from
ReorderFunctionsWindowSize though...

[qining, 2015/06/24 20:18:55]

Done.

+  uint32_t ReorderFunctionsWindowSize;
+
+  // Global variable reordering option
+  bool ReorderGlobalVariables;
+
+  // Pooled constant reordering option
+  bool ReorderPooledConstants;
+
   size_t NumTranslationThreads; // 0 means completely sequential
   uint64_t RandomSeed;
 };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICECLFLAGS_H