Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1206533002: [turbofan] Run DeadCodeElimination together with the advanced reducers. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Run DeadCodeElimination together with the advanced reducers. This will immediately remove dead code from the graph once any of the advanced reducers inserts it. Also changes the GraphReducer to use the canonical Dead node for ReplaceWithValue. R=jarin@chromium.org Committed: https://crrev.com/88a40c5fb381924b1c0b2403dc582bceb2abe5da Cr-Commit-Position: refs/heads/master@{#29217} Committed: https://chromium.googlesource.com/v8/v8/+/64d6ab455d5749f7d8c93f99943e0ef67a2266bc

Patch Set 1 #

Patch Set 2 : Fix test262 test failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -74 lines) Patch
M src/compiler/common-operator-reducer.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/common-operator-reducer.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M src/compiler/graph-reducer.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/graph-reducer.cc View 2 chunks +7 lines, -11 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 1 chunk +10 lines, -23 lines 0 comments Download
M src/compiler/pipeline.cc View 6 chunks +10 lines, -16 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -4 lines 0 comments Download
M test/unittests/compiler/graph-reducer-unittest.cc View 5 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-23 08:22:29 UTC) #1
Benedikt Meurer
Hey Jaro, Hopefully one of the last DCE CLs. Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-23 08:24:28 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-23 08:32:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206533002/1
5 years, 6 months ago (2015-06-23 08:32:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 08:48:21 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/88a40c5fb381924b1c0b2403dc582bceb2abe5da Cr-Commit-Position: refs/heads/master@{#29217}
5 years, 6 months ago (2015-06-23 08:48:47 UTC) #7
Benedikt Meurer
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1200983004/ by bmeurer@chromium.org. ...
5 years, 6 months ago (2015-06-23 09:38:46 UTC) #8
Benedikt Meurer
5 years, 6 months ago (2015-06-23 11:22:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
64d6ab455d5749f7d8c93f99943e0ef67a2266bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698