Source/modules/presentation/PresentationController.cpp - Issue 1206513004: [PresentationAPI] on-session-message handler for binary messages (Blink side).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/presentation/PresentationController.cpp

Issue 1206513004: [PresentationAPI] on-session-message handler for binary messages (Blink side). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased. layout test update. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/presentation/Presentation.cpp ('K') | « Source/modules/presentation/PresentationController.h ('k') | Source/modules/presentation/PresentationSession.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/presentation/PresentationController.cpp

diff --git a/Source/modules/presentation/PresentationController.cpp b/Source/modules/presentation/PresentationController.cpp

index f3b84a851d2e7ff9ebbf9450b42bd90eadd44cde..dee985a8ac41c40966fd5ee80463e467cf66e659 100644

--- a/Source/modules/presentation/PresentationController.cpp

+++ b/Source/modules/presentation/PresentationController.cpp

@@ -102,6 +102,14 @@ void PresentationController::didReceiveSessionTextMessage(WebPresentationSession

PresentationSession::dispose(sessionClient);

}

+void PresentationController::didReceiveSessionBinaryMessage(WebPresentationSessionClient* sessionClient, const uint8_t* data, size_t length)

+ if (m_presentation)

+ m_presentation->didReceiveSessionBinaryMessage(sessionClient, data, length);

+ else

+ PresentationSession::dispose(sessionClient);

mark a. foltz 2015/07/06 21:19:45 Please refactor to use the form suggested in https

USE s.singapati at gmail.com 2015/07/07 15:00:33 Done.

void PresentationController::startSession(const String& presentationUrl, const String& presentationId, WebPresentationSessionClientCallbacks* callbacks)

{

if (!m_client) {