Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1212423003: Presentation API: Blink changes to allow getAvailability() to be rejected. (Closed)

Created:
5 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 5 months ago
Reviewers:
mark a. foltz, whywhat
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@presentation-availability-cleanups
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Presentation API: Blink changes to allow getAvailability() to be rejected. This is adding a AvailabilityNotSupported error in PresentationError. It is also refactoring some callback code to be in sync with CallbackPromiseAdapter. As a consequence, PresentationSession::dispose() has been removed. BUG=507295 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -52 lines) Patch
M Source/modules/presentation/Presentation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/presentation/PresentationAvailabilityCallback.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/modules/presentation/PresentationAvailabilityCallback.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M Source/modules/presentation/PresentationController.cpp View 2 chunks +13 lines, -9 lines 0 comments Download
M Source/modules/presentation/PresentationError.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/presentation/PresentationError.cpp View 2 chunks +6 lines, -12 lines 0 comments Download
M Source/modules/presentation/PresentationSession.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/presentation/PresentationSession.cpp View 1 chunk +2 lines, -9 lines 0 comments Download
M Source/modules/presentation/PresentationSessionClientCallbacks.cpp View 1 chunk +8 lines, -12 lines 0 comments Download
M public/platform/modules/presentation/WebPresentationClient.h View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/modules/presentation/WebPresentationError.h View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
mlamouri (slow - plz ping)
5 years, 5 months ago (2015-07-06 17:07:00 UTC) #2
whywhat
lgtm
5 years, 5 months ago (2015-07-06 17:14:02 UTC) #3
mark a. foltz
lgtm Can you update the description to include the removal of PresentationSession::dispose()?
5 years, 5 months ago (2015-07-06 19:49:03 UTC) #4
mlamouri (slow - plz ping)
On 2015/07/06 at 19:49:03, mfoltz wrote: > lgtm > > Can you update the description ...
5 years, 5 months ago (2015-07-06 19:53:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212423003/1
5 years, 5 months ago (2015-07-07 10:32:57 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 12:03:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198394

Powered by Google App Engine
This is Rietveld 408576698