Chromium Code Reviews| Index: sky/sdk/lib/widgets/basic.dart |
| diff --git a/sky/sdk/lib/widgets/basic.dart b/sky/sdk/lib/widgets/basic.dart |
| index 511bd4b81ac545e47eb695fc54ba0ce47f9dd6c4..90ab7af5ebf421999808a1e4ce4663643c8aeb95 100644 |
| --- a/sky/sdk/lib/widgets/basic.dart |
| +++ b/sky/sdk/lib/widgets/basic.dart |
| @@ -104,6 +104,27 @@ class ClipRect extends OneChildRenderObjectWrapper { |
| RenderClipRect get root => super.root; |
| RenderClipRect createNode() => new RenderClipRect(); |
| + |
| + void syncRenderObject(ClipRect old) { |
| + // ClipRect has nothing to sync |
|
Hixie
2015/06/25 18:24:47
see comment below
|
| + super.syncRenderObject(old); |
| + } |
| +} |
| + |
| +class ClipRRect extends OneChildRenderObjectWrapper { |
| + final double xRadius; |
| + final double yRadius; |
| + ClipRRect({ String key, Widget child, this.xRadius, this.yRadius }) |
| + : super(key: key, child: child); |
| + |
| + RenderClipRRect get root => super.root; |
| + RenderClipRRect createNode() => new RenderClipRRect(xRadius: xRadius, yRadius: yRadius); |
| + |
| + void syncRenderObject(ClipRRect old) { |
| + super.syncRenderObject(old); |
| + root.xRadius = xRadius; |
| + root.yRadius = yRadius; |
| + } |
| } |
| class ClipOval extends OneChildRenderObjectWrapper { |
| @@ -112,8 +133,12 @@ class ClipOval extends OneChildRenderObjectWrapper { |
| RenderClipOval get root => super.root; |
| RenderClipOval createNode() => new RenderClipOval(); |
| -} |
| + void syncRenderObject(ClipOval old) { |
|
Hixie
2015/06/25 18:24:47
Don't have functions that do nothing but call supe
|
| + // ClipOval has nothing to sync |
| + super.syncRenderObject(old); |
| + } |
| +} |
| // POSITIONING AND SIZING NODES |
| @@ -427,6 +452,17 @@ class Text extends Component { |
| } |
| } |
| +enum ObjectFit { fill, contain, cover, none, scaleDown } |
| + |
| +// class Image extends Component { |
| +// Image(this.src, { String key, this.fit }) : super(key: key); |
| +// final ObjectFit fit; |
| +// Size size; |
| +// Widget build() { |
| +// return new SizedImage(src: src, size: size); |
| +// } |
| +// } |
| + |
|
abarth-chromium
2015/06/25 18:04:12
Looks like this part of the diff is from your next
|
| class Image extends LeafRenderObjectWrapper { |
| Image({ |