Implement ClipRRect

sky/sdk/lib/widgets/basic.dart

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 import 'dart:sky' as sky;
 
 import 'package:vector_math/vector_math.dart';
 
 import '../painting/text_style.dart';
 import '../rendering/block.dart';
@@ skipping 86 matching lines @@
   }
 
 }
 
 class ClipRect extends OneChildRenderObjectWrapper {
   ClipRect({ String key, Widget child })
     : super(key: key, child: child);
 
   RenderClipRect get root => super.root;
   RenderClipRect createNode() => new RenderClipRect();
+
+  void syncRenderObject(ClipRect old) {
+    // ClipRect has nothing to sync

[Hixie, 2015/06/25 18:24:47]

see comment below

+    super.syncRenderObject(old);
+  }
+}
+
+class ClipRRect extends OneChildRenderObjectWrapper {
+  final double xRadius;
+  final double yRadius;
+  ClipRRect({ String key, Widget child, this.xRadius, this.yRadius })
+    : super(key: key, child: child);
+
+  RenderClipRRect get root => super.root;
+  RenderClipRRect createNode() => new RenderClipRRect(xRadius: xRadius, yRadius: yRadius);
+
+  void syncRenderObject(ClipRRect old) {
+    super.syncRenderObject(old);
+    root.xRadius = xRadius;
+    root.yRadius = yRadius;
+  }
 }
 
 class ClipOval extends OneChildRenderObjectWrapper {
   ClipOval({ String key, Widget child })
     : super(key: key, child: child);
 
   RenderClipOval get root => super.root;
   RenderClipOval createNode() => new RenderClipOval();
+
+  void syncRenderObject(ClipOval old) {

[Hixie, 2015/06/25 18:24:47]

Don't have functions that do nothing but call super, that's just wasted cycles.

Maybe have a comment to the effect of
// ClipOval has nothing to sync, so doesn't implement syncRenderObject()
...or something?

+    // ClipOval has nothing to sync
+    super.syncRenderObject(old);
+  }
 }
 
-
 // POSITIONING AND SIZING NODES
 
 class Transform extends OneChildRenderObjectWrapper {
 
   Transform({ String key, this.transform, Widget child })
     : super(key: key, child: child);
 
   RenderTransform get root => super.root;
   final Matrix4 transform;
 
@@ skipping 292 matching lines @@
         combinedStyle = defaultStyle;
     } else {
       combinedStyle = style;      
     }
     if (combinedStyle != null)
       text = new InlineStyle(combinedStyle, [text]);
     return new Inline(text: text);
   }
 }
 
+enum ObjectFit { fill, contain, cover, none, scaleDown }
+
+// class Image extends Component {
+//   Image(this.src, { String key, this.fit }) : super(key: key);
+//   final ObjectFit fit;
+//   Size size;
+//   Widget build() {
+//     return new SizedImage(src: src, size: size);
+//   }
+// }
+

[abarth-chromium, 2015/06/25 18:04:12]

Looks like this part of the diff is from your next CL.  :)

 class Image extends LeafRenderObjectWrapper {
 
   Image({
     src,
     this.size
   }) : src = src,
        super(key: src) {
     assert(src != null);
   }
 
@@ skipping 31 matching lines @@
   }
 
   void remove() {
     RenderObjectWrapper ancestor = findAncestor(RenderObjectWrapper);
     assert(ancestor is RenderObjectWrapper);
     ancestor.detachChildRoot(this);
     super.remove();
   }
 
 }