Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1206333003: Revert of Cleanup legacy NVPR-related definitions (Closed)

Created:
5 years, 6 months ago by f(malita)
Modified:
5 years, 6 months ago
CC:
reviews_skia.org, Chris Dalton
Base URL:
https://skia.googlesource.com/skia.git@chromium-pathrendering-prepare-02
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Cleanup legacy NVPR-related definitions (patchset #3 id:40001 of https://codereview.chromium.org/1177243004/) Reason for revert: Broke the GPU SAN bots: https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Debug-ASAN/builds/779/steps/dm/logs/stdio Original issue's description: > Cleanup legacy NVPR-related definitions > > Fixed-function NVPR codepaths were removed a while ago. Only NVPR API > version 1.3 (PathFragmentInputGen) was left working. Remove > backwards-compatibility code that was left behind. > > Remove some NVPR API function typedefs that were left from initial > commits. > > Remove PathCoords function pointer from GrGLInterface, it has > never been called and causes problems in the future, since it will > not be implemented in the Chromium pseudo extension. > > Committed: https://skia.googlesource.com/skia/+/fb8d6884e0e01d0c2f8596adf5af1efb0d08de7e TBR=joshualitt@google.com,cdalton@nvidia.com,bsalomon@google.com,kkinnunen@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/538bacb4bb3ceac7786108cd68b04ed58b1c29c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -16 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 2 chunks +10 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 3 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 4 chunks +20 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.h View 2 chunks +33 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 5 chunks +70 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
f(malita)
Created Revert of Cleanup legacy NVPR-related definitions
5 years, 6 months ago (2015-06-25 15:42:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206333003/1
5 years, 6 months ago (2015-06-25 15:42:18 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 15:42:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/538bacb4bb3ceac7786108cd68b04ed58b1c29c7

Powered by Google App Engine
This is Rietveld 408576698