Update ChannelReader to use AttachmentBroker.

ipc/brokerable_attachment.cc

Index: ipc/brokerable_attachment.cc
diff --git a/ipc/brokerable_attachment.cc b/ipc/brokerable_attachment.cc
index 764f2b20a4fa3879241e6b7a3d4582056b8f79bc..9af40d9ed50197bf473699bb1e5a82d29a13a984 100644
--- a/ipc/brokerable_attachment.cc
+++ b/ipc/brokerable_attachment.cc
@@ -21,10 +21,13 @@ BrokerableAttachment::AttachmentId GetRandomId() {
 
 }  // namespace
 
-BrokerableAttachment::BrokerableAttachment() : id_(GetRandomId()) {
+BrokerableAttachment::BrokerableAttachment()
+    : id_(GetRandomId()), needs_brokering_(false) {
 }
 
-BrokerableAttachment::BrokerableAttachment(const AttachmentId& id) : id_(id) {
+BrokerableAttachment::BrokerableAttachment(const AttachmentId& id,
+                                           bool needs_brokering)
+    : id_(id), needs_brokering_(needs_brokering) {
 }
 
 BrokerableAttachment::~BrokerableAttachment() {
@@ -34,6 +37,14 @@ BrokerableAttachment::AttachmentId BrokerableAttachment::GetIdentifier() const {
   return id_;
 }
 
+bool BrokerableAttachment::NeedsBrokering() const {

[Tom Sepez, 2015/07/13 18:28:47]

Any reason not to just make these inline in the header to maybe avoid a function
call?

[erikchen, 2015/07/17 18:44:01]

I try to keep as much code as possible out of header files. I claim that modern
compilers are smart enough that for optimized binaries, there is minimal
correlation between the location of the definition (.cc vs .h) and whether the
function ends up inlined.

+  return needs_brokering_;
+}
+
+void BrokerableAttachment::SetNeedsBrokering(bool needs_brokering) {
+  needs_brokering_ = needs_brokering;
+}
+
 BrokerableAttachment::Type BrokerableAttachment::GetType() const {
   return TYPE_BROKERABLE_ATTACHMENT;
 }