Update ChannelReader to use AttachmentBroker.

ipc/brokerable_attachment.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/brokerable_attachment.h"
 
 #include "crypto/random.h"
 
 namespace IPC {
 
 namespace {
 
 // In order to prevent mutually untrusted processes from stealing resources from
 // one another, the nonce must be secret. This generates a 128-bit,
 // cryptographicaly-strong random number.
 BrokerableAttachment::AttachmentId GetRandomId() {
   BrokerableAttachment::AttachmentId id;
   crypto::RandBytes(id.nonce, BrokerableAttachment::kNonceSize);
   return id;
 }
 
 }  // namespace
 
-BrokerableAttachment::BrokerableAttachment() : id_(GetRandomId()) {
+BrokerableAttachment::BrokerableAttachment()
+    : id_(GetRandomId()), needs_brokering_(false) {
 }
 
-BrokerableAttachment::BrokerableAttachment(const AttachmentId& id) : id_(id) {
+BrokerableAttachment::BrokerableAttachment(const AttachmentId& id,
+                                           bool needs_brokering)
+    : id_(id), needs_brokering_(needs_brokering) {
 }
 
 BrokerableAttachment::~BrokerableAttachment() {
 }
 
 BrokerableAttachment::AttachmentId BrokerableAttachment::GetIdentifier() const {
   return id_;
 }
 
+bool BrokerableAttachment::NeedsBrokering() const {

[Tom Sepez, 2015/07/13 18:28:47]

Any reason not to just make these inline in the header to maybe avoid a function
call?

[erikchen, 2015/07/17 18:44:01]

I try to keep as much code as possible out of header files. I claim that modern
compilers are smart enough that for optimized binaries, there is minimal
correlation between the location of the definition (.cc vs .h) and whether the
function ends up inlined.

+  return needs_brokering_;
+}
+
+void BrokerableAttachment::SetNeedsBrokering(bool needs_brokering) {
+  needs_brokering_ = needs_brokering;
+}
+
 BrokerableAttachment::Type BrokerableAttachment::GetType() const {
   return TYPE_BROKERABLE_ATTACHMENT;
 }
 
 }  // namespace IPC