Rework how isolates are generated in MB.

Rework how isolates are generated in MB.

This patch changes how MB will generate the .isolate files
for a GN build:

First, we rename 'ninja_to_gn.pyl' to 'gn_isolate_map.pyl',
and change it from a straight compile_target -> gn_label map to
a map of compile_target -> { "label": gn_label, "type": string}.

Valid values for "type" are
"windowed_test_launcher"
: the test is a gtest-based test that uses the
  'brave-new-test-launcher' from //base/test:test_support and
  needs to run under Xvfb if run on an X11-based platform
  (i.e., if use_x11=true in GN).
"console_test_launcher"
: the test is a gtest-based test that uses the
  'brave-new-test-launcher' from //base/test:test_support but does
  not need Xvfb.
"raw"
: the test is just an executable and may take an optional list
  of command-line arguments, but does not need any extra files
  or other special processing.
"unknown"
: (the default), which indicates that we don't know what the command
  line needs to be (this is a fatal error).

Second, we read the new file in, and build a lookup map of test
types to command lines. We will probably need to keep iterating
on the list of test types and command lines, and perhaps provide
some escape hatches so that we can handle the full variety of tests.

For now, we only know how to handle base_unittests, ui_base_unittests,
and cacheinvalidation_unittests.

R=maruel@chromium.org, brettw@chromium.org, sky@chromium.org
BUG=503942, 504079
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel

[M-A Ruel, 2015-06-25 14:49:22]

Interesting, lgtm

https://codereview.chromium.org/1206033005/diff/80001/testing/buildbot/manage.py
File testing/buildbot/manage.py (right):

https://codereview.chromium.org/1206033005/diff/80001/testing/buildbot/manage...
testing/buildbot/manage.py:272: ninja_targets = dict((k, v['label']) for k, v in
gn_isolate_map.items())
ninja_targets = {k: v['label'] for k, v in gn_isolate_map.iteritems()}

https://codereview.chromium.org/1206033005/diff/80001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/1206033005/diff/80001/tools/mb/mb.py#newcode528
tools/mb/mb.py:528: elif test_type in ('windowed_test_launcher',
'console_test_launcher'):
sort

[Dirk Pranke, 2015-07-21 00:53:33]

dpranke@chromium.org changed reviewers:
+ sky@chromium.org

[Dirk Pranke, 2015-07-21 20:33:28]

Patchset #12 (id:210001) has been deleted

[Dirk Pranke, 2015-07-21 20:33:40]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org

[Dirk Pranke, 2015-07-21 21:04:42]

Minor changes after the lgtm:

- added a new 'raw' type to handle cases where we don't need anything fancy
- added handling for cacheinvalidation_unittests
- added proper handling for ui_base_unittests

[Dirk Pranke, 2015-07-21 21:05:33]

Brett, can you look at third_party/cacheinvalidation and ui/base ; Scott, can
you look at just ui/base?

Maruel already covered the other stuff.

[Dirk Pranke, 2015-07-21 21:40:37]

On 2015/07/21 21:05:33, Dirk Pranke wrote:
> Brett, can you look at third_party/cacheinvalidation and ui/base ; Scott, can
> you look at just ui/base?
> 
> Maruel already covered the other stuff.

Closing ... Brett, Scott, please take a look at
https://codereview.chromium.org/1246103005 instead.