Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1205703008: Revert of Implement four more xfermodes with Sk4px. (Closed)

Created:
5 years, 6 months ago by mtklein
Modified:
5 years, 6 months ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Implement four more xfermodes with Sk4px. (patchset #16 id:290001 of https://codereview.chromium.org/1196713004/) Reason for revert: 64-bit ARM build failures. Original issue's description: > Implement four more xfermodes with Sk4px. > > HardLight, Overlay, Darken, and Lighten are all > ~2x faster with SSE, ~25% faster with NEON. > > This covers all previously-implemented NEON xfermodes. > 3 previous SSE xfermodes remain. Those need division > and sqrt, so I'm planning on using SkPMFloat for them. > It'll help the readability and NEON speed if I move that > into [0,1] space first. > > The main new concept here is c.thenElse(t,e), which behaves like > (c ? t : e) except, of course, both t and e are evaluated. This allows > us to emulate conditionals with vectors. > > This also removes the concept of SkNb. Instead of a standalone bool > vector, each SkNi or SkNf will just return their own types for > comparisons. Turns out to be a lot more manageable this way. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/b9d4163bebab0f5639f9c5928bb5fc15f472dddc TBR=reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/0cc1f0a8d5ed69c76d75061bc2dee3b1d0ce0605

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -197 lines) Patch
M src/core/Sk4px.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/Sk4pxXfermode.h View 3 chunks +9 lines, -51 lines 0 comments Download
M src/core/SkNx.h View 9 chunks +49 lines, -43 lines 0 comments Download
M src/opts/SkNx_neon.h View 9 chunks +60 lines, -58 lines 0 comments Download
M src/opts/SkNx_sse.h View 10 chunks +57 lines, -37 lines 0 comments Download
M src/opts/SkXfermode_opts_SSE2.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M src/opts/SkXfermode_opts_arm_neon.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Implement four more xfermodes with Sk4px.
5 years, 6 months ago (2015-06-24 21:30:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205703008/1
5 years, 6 months ago (2015-06-24 21:30:36 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 21:30:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0cc1f0a8d5ed69c76d75061bc2dee3b1d0ce0605

Powered by Google App Engine
This is Rietveld 408576698