Source/modules/webgl/WebGLFramebuffer.h - Issue 1205573003: WebGL 2: validate read buffer attachment when reading from FBO

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webgl/WebGLFramebuffer.h

Issue 1205573003: WebGL 2: validate read buffer attachment when reading from FBO (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed zmo@'s and kbr@'s feedback, and rebased the code Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/webgl/WebGL2RenderingContextBase.cpp ('K') | « Source/modules/webgl/WebGL2RenderingContextBase.cpp ('k') | Source/modules/webgl/WebGLFramebuffer.cpp » ('j') | Source/modules/webgl/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webgl/WebGLFramebuffer.h

diff --git a/Source/modules/webgl/WebGLFramebuffer.h b/Source/modules/webgl/WebGLFramebuffer.h

index 9dd5ee170e36010458f9775f44c46448a7a2a26f..bdd3c7309e438dfc7a195cbc538ecfb0bdb76929 100644

--- a/Source/modules/webgl/WebGLFramebuffer.h

+++ b/Source/modules/webgl/WebGLFramebuffer.h

@@ -103,6 +103,10 @@ public:

GLenum getDrawBuffer(GLenum);

+ void readBuffer(const GLenum colorBuffer) { m_readBuffer = colorBuffer; }

+ GLenum getReadBuffer() const { return m_readBuffer; }

DECLARE_VIRTUAL_TRACE();

protected:

@@ -134,6 +138,8 @@ private:

Vector<GLenum> m_drawBuffers;

Vector<GLenum> m_filteredDrawBuffers;

+ GLenum m_readBuffer;

};

} // namespace blink