Source/core/html/canvas/WebGLRenderingContextBase.h - Issue 1205573003: WebGL 2: validate read buffer attachment when reading from FBO

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLRenderingContextBase.h

Issue 1205573003: WebGL 2: validate read buffer attachment when reading from FBO (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed zmo@'s feedback: readbuffer is per framebuffer, not per rendering context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/canvas/WebGL2RenderingContextBase.cpp ('K') | « Source/core/html/canvas/WebGLFramebuffer.cpp ('k') | Source/core/html/canvas/WebGLRenderingContextBase.cpp » ('j') | Source/core/html/canvas/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGLRenderingContextBase.h

diff --git a/Source/core/html/canvas/WebGLRenderingContextBase.h b/Source/core/html/canvas/WebGLRenderingContextBase.h

index 0f6d7275e4c260c67cdaff6525afe92277df88d8..1a9f54898c4e21421e2dcb7d1a9ee37298b0d754 100644

--- a/Source/core/html/canvas/WebGLRenderingContextBase.h

+++ b/Source/core/html/canvas/WebGLRenderingContextBase.h

@@ -862,6 +862,10 @@ protected:

// the given format.

bool validateCompressedTexSubDimensions(const char* functionName, GLenum target, GLint level, GLint xoffset, GLint yoffset, GLsizei width, GLsizei height, GLenum format, WebGLTexture*);

+ // Helper function to validate that the image is attached to read buffer

+ // when reading from FBO (readPixels/copyTexImage2D/copyTexSubImage2D).

+ bool validateReadBufferAttachment(const char* functionName, const WebGLFramebuffer* readFramebufferBinding);

// Helper function to validate mode for draw{Arrays/Elements}.

bool validateDrawMode(const char* functionName, GLenum);