Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 1205473004: [turbofan] Make global variable loads and stores explicit. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make global variable loads and stores explicit. This is a precursor to using specialized LoadIC and StoreIC stubs for global variable access. It also removes the need to keep track of the global object in the type system, hence freeing up one bit. R=bmeurer@chromium.org Committed: https://crrev.com/7f5a2d9ed530dddf29232f6d29ca850df1b1cf90 Cr-Commit-Position: refs/heads/master@{#29231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -137 lines) Patch
M src/compiler/ast-graph-builder.h View 2 chunks +8 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 4 chunks +29 lines, -7 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +27 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 6 chunks +14 lines, -4 lines 0 comments Download
M src/compiler/js-operator.cc View 4 chunks +38 lines, -3 lines 0 comments Download
M src/compiler/js-type-feedback.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-type-feedback.cc View 4 chunks +6 lines, -14 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 3 chunks +11 lines, -15 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 4 chunks +13 lines, -5 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/types.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/types.cc View 2 chunks +1 line, -2 lines 0 comments Download
M test/cctest/test-types.cc View 4 chunks +2 lines, -74 lines 0 comments Download
M test/unittests/compiler/js-type-feedback-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-23 12:19:51 UTC) #1
Benedikt Meurer
LGTM. Thanks.
5 years, 6 months ago (2015-06-23 12:23:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205473004/1
5 years, 6 months ago (2015-06-23 13:09:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 13:34:05 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 13:34:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f5a2d9ed530dddf29232f6d29ca850df1b1cf90
Cr-Commit-Position: refs/heads/master@{#29231}

Powered by Google App Engine
This is Rietveld 408576698