pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart - Issue 1205373002: Translate package URIs to resource URIs for diagnostics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

Issue 1205373002: Translate package URIs to resource URIs for diagnostics. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Use resourceUri instead of readableUri in source spans. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

diff --git a/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart b/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

index 51ab110822a6f9bfe708270b64ed7876c4da2064..5bf4b1edf9dc33779b6ecbd125cb00477cfe8844 100644

--- a/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

+++ b/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

@@ -193,11 +193,11 @@ abstract class Dart2JsElementMirror extends Dart2JsDeclarationMirror {

Script script = getScript();

SourceSpan span;

if (beginToken == null) {

- span = new SourceSpan(script.readableUri, 0, 0);

+ span = new SourceSpan(script.resourceUri, 0, 0);

} else {

Token endToken = getEndToken();

span = mirrorSystem.compiler.spanFromTokens(

- beginToken, endToken, script.readableUri);

+ beginToken, endToken, script.resourceUri);

}

return new Dart2JsSourceLocation(script, span);

}