pkg/compiler/lib/src/elements/modelx.dart - Issue 1205373002: Translate package URIs to resource URIs for diagnostics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/elements/modelx.dart

Issue 1205373002: Translate package URIs to resource URIs for diagnostics. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Use resourceUri instead of readableUri in source spans. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/elements/modelx.dart

diff --git a/pkg/compiler/lib/src/elements/modelx.dart b/pkg/compiler/lib/src/elements/modelx.dart

index cf96f4e3ebefd2be3fa6bc5641a039a4e4864a40..078fa87990975e8e776570f88d7435cfaa436977 100644

--- a/pkg/compiler/lib/src/elements/modelx.dart

+++ b/pkg/compiler/lib/src/elements/modelx.dart

@@ -114,7 +114,7 @@ abstract class ElementX extends Element with ElementCommon {

SourceSpan get sourcePosition {

if (position == null) return null;

- Uri uri = compilationUnit.script.readableUri;

+ Uri uri = compilationUnit.script.resourceUri;

return new SourceSpan(

uri, position.charOffset, position.charOffset + position.charCount);

}