Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1205353002: [turbofan] Optimize BooleanNot conditions to Branch nodes. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize BooleanNot conditions to Branch nodes. Also remove the weird work-around for this missing optimization in CHECK_DATE in macros.py. R=svenpanne@chromium.org Committed: https://crrev.com/35eb3a0260d349cb4201fed66ff62a438962bd47 Cr-Commit-Position: refs/heads/master@{#29288}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M src/compiler/common-operator-reducer.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M src/macros.py View 1 chunk +1 line, -1 line 2 comments Download
M test/unittests/compiler/common-operator-reducer-unittest.cc View 4 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-25 09:44:54 UTC) #1
Benedikt Meurer
Hey Sven, Another trivial optimization. Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-25 09:45:16 UTC) #2
Sven Panne
https://codereview.chromium.org/1205353002/diff/1/src/macros.py File src/macros.py (right): https://codereview.chromium.org/1205353002/diff/1/src/macros.py#newcode194 src/macros.py:194: macro CHECK_DATE(arg) = if (!%_IsDate(arg)) %_ThrowNotDateError(); Hopefully not followed ...
5 years, 6 months ago (2015-06-25 09:54:53 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1205353002/diff/1/src/macros.py File src/macros.py (right): https://codereview.chromium.org/1205353002/diff/1/src/macros.py#newcode194 src/macros.py:194: macro CHECK_DATE(arg) = if (!%_IsDate(arg)) %_ThrowNotDateError(); On 2015/06/25 09:54:52, ...
5 years, 6 months ago (2015-06-25 10:17:20 UTC) #4
Sven Panne
lgtm
5 years, 6 months ago (2015-06-25 10:59:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205353002/1
5 years, 6 months ago (2015-06-25 10:59:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205353002/1
5 years, 6 months ago (2015-06-25 10:59:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-25 11:07:05 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 11:07:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35eb3a0260d349cb4201fed66ff62a438962bd47
Cr-Commit-Position: refs/heads/master@{#29288}

Powered by Google App Engine
This is Rietveld 408576698