src/macros.py - Issue 1205353002: [turbofan] Optimize BooleanNot conditions to Branch nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/macros.py

Issue 1205353002: [turbofan] Optimize BooleanNot conditions to Branch nodes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/macros.py

diff --git a/src/macros.py b/src/macros.py

index 0b5bcb51533e96c01f42a2d4662f33d29fe96468..5e28c66a83a445530fbddb2518f8efa23ad6dae8 100644

--- a/src/macros.py

+++ b/src/macros.py

@@ -191,7 +191,7 @@ define MAX_TIME_BEFORE_UTC = 8640002592000000;

# Gets the value of a Date object. If arg is not a Date object

# a type error is thrown.

-macro CHECK_DATE(arg) = if (%_IsDate(arg)) {} else %_ThrowNotDateError();

+macro CHECK_DATE(arg) = if (!%_IsDate(arg)) %_ThrowNotDateError();

Sven Panne 2015/06/25 09:54:52 Hopefully not followed by an "else"... :-]

Benedikt Meurer 2015/06/25 10:17:20 It was this way before. Just removed the negation

macro LOCAL_DATE_VALUE(arg) = (%_DateField(arg, 0) + %_DateField(arg, 21));

macro UTC_DATE_VALUE(arg) = (%_DateField(arg, 0));

« no previous file with comments | « src/compiler/common-operator-reducer.cc ('k') | test/unittests/compiler/common-operator-reducer-unittest.cc » ('j') | no next file with comments »