Issue 12052024: [Telemetry] Dynamically set remote debugging port in DesktopBrowserBackend.

Issue 12052024: [Telemetry] Dynamically set remote debugging port in DesktopBrowserBackend. (Closed)

Created:
7 years, 11 months ago by hartmanng

Modified:
7 years, 11 months ago

Reviewers:
nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Dynamically set remote debugging port in DesktopBrowserBackend. BUG=163093 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178234

Patch Set 3 : s/GetLocalPort/GetAvailableLocalPort/ #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
M	tools/telemetry/telemetry/cros_browser_backend.py	View	1 2	2 chunks	+1 line, -5 lines	0 comments	Download
M	tools/telemetry/telemetry/desktop_browser_backend.py	View	1 2	2 chunks	+2 lines, -3 lines	0 comments	Download
M	tools/telemetry/telemetry/temporary_http_server.py	View	1 2	1 chunk	+1 line, -5 lines	0 comments	Download
M	tools/telemetry/telemetry/util.py	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

nduca

https://codereview.chromium.org/12052024/diff/1/tools/telemetry/telemetry/desktop_browser_backend.py File tools/telemetry/telemetry/desktop_browser_backend.py (right): https://codereview.chromium.org/12052024/diff/1/tools/telemetry/telemetry/desktop_browser_backend.py#newcode12 tools/telemetry/telemetry/desktop_browser_backend.py:12: from pylib import ports # pylint: disable=F0401 I'd rather ...

7 years, 11 months ago (2013-01-22 21:20:08 UTC) #2

hartmanng

On 2013/01/22 21:20:08, nduca wrote: > Pylib is android Didn't realize that, fixed (also consolidated ...

7 years, 11 months ago (2013-01-22 22:32:15 UTC) #3

nduca

https://codereview.chromium.org/12052024/diff/3002/tools/telemetry/telemetry/util.py File tools/telemetry/telemetry/util.py (right): https://codereview.chromium.org/12052024/diff/3002/tools/telemetry/telemetry/util.py#newcode62 tools/telemetry/telemetry/util.py:62: def GetLocalPort(): Lgtm but GetAvailableLocalPort() maybe?

7 years, 11 months ago (2013-01-22 22:38:57 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hartmanng@chromium.org/12052024/2007

7 years, 11 months ago (2013-01-22 22:57:13 UTC) #5

Message was sent while issue was closed.

Change committed as 178234

Expand Messages | Collapse Messages