Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: tools/telemetry/telemetry/cros_browser_backend.py

Issue 12052024: [Telemetry] Dynamically set remote debugging port in DesktopBrowserBackend. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: s/GetLocalPort/GetAvailableLocalPort/ Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/desktop_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/cros_browser_backend.py
diff --git a/tools/telemetry/telemetry/cros_browser_backend.py b/tools/telemetry/telemetry/cros_browser_backend.py
index 5b512bd306e01eed088d401c875250e0a5fa3c34..9453e92cc654fb0a08c115e8c0b001ffbe6e96e2 100644
--- a/tools/telemetry/telemetry/cros_browser_backend.py
+++ b/tools/telemetry/telemetry/cros_browser_backend.py
@@ -3,7 +3,6 @@
# found in the LICENSE file.
import logging
import os
-import socket
import subprocess
from telemetry import browser_backend
@@ -48,10 +47,7 @@ class CrOSBrowserBackend(browser_backend.BrowserBackend):
cri.GetCmdOutput(args)
# Find a free local port.
- tmp = socket.socket()
- tmp.bind(('', 0))
- self._port = tmp.getsockname()[1]
- tmp.close()
+ self._port = util.GetAvailableLocalPort()
# Forward the remote debugging port.
logging.info('Forwarding remote debugging port')
« no previous file with comments | « no previous file | tools/telemetry/telemetry/desktop_browser_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698