Don't expose DocumentWriter to embedding layer

Source/core/page/PagePopupClient.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef PagePopupClient_h
 #define PagePopupClient_h
 
-#include "core/loader/DocumentWriter.h"
+#include "platform/SharedBuffer.h"
 #include "platform/geometry/IntRect.h"
 #include "wtf/text/CString.h"
 #include "wtf/text/WTFString.h"
 
 namespace WebCore {
 
-class DocumentWriter;
 class Locale;
 
 class PagePopupClient {
 public:
     virtual IntSize contentSize() = 0;
 
-    // Provide an HTML source through the specified DocumentWriter. The HTML
+    // Provide an HTML source to the specified buffer. The HTML
     // source is rendered in a PagePopup.
     // The content HTML supports:
     //  - No <select> popups
     //  - window.setValueAndClosePopup(number, string).
-    virtual void writeDocument(DocumentWriter&) = 0;
+    virtual void writeDocument(SharedBuffer*) = 0;
 
     // Returns a Locale object associated to the client.
     virtual Locale& locale() = 0;
 
     // This is called by the content HTML of a PagePopup.
     // An implementation of this function should call ChromeClient::closePagePopup().
     virtual void setValueAndClosePopup(int numValue, const String& stringValue) = 0;
 
     // This is called by the content HTML of a PagePopup.
     virtual void setValue(const String&) = 0;
 
     // This is called by the content HTML of a PagePopup.
     virtual void closePopup() = 0;
 
     // This is called whenever a PagePopup was closed.
     virtual void didClosePopup() = 0;
 
     virtual ~PagePopupClient() { }
 
     // Helper functions to be used in PagePopupClient::writeDocument().
-    static void addString(const String&, DocumentWriter&);
-    static void addJavaScriptString(const String&, DocumentWriter&);
-    static void addProperty(const char* name, const String& value, DocumentWriter&);
-    static void addProperty(const char* name, int value, DocumentWriter&);
-    static void addProperty(const char* name, unsigned value, DocumentWriter&);
-    static void addProperty(const char* name, bool value, DocumentWriter&);
-    static void addProperty(const char* name, const Vector<String>& values, DocumentWriter&);
-    static void addProperty(const char* name, const IntRect&, DocumentWriter&);
+    static void addString(const String&, SharedBuffer*);
+    static void addJavaScriptString(const String&, SharedBuffer*);
+    static void addProperty(const char* name, const String& value, SharedBuffer*);
+    static void addProperty(const char* name, int value, SharedBuffer*);
+    static void addProperty(const char* name, unsigned value, SharedBuffer*);
+    static void addProperty(const char* name, bool value, SharedBuffer*);
+    static void addProperty(const char* name, const Vector<String>& values, SharedBuffer*);
+    static void addProperty(const char* name, const IntRect&, SharedBuffer*);
 };
 
-inline void PagePopupClient::addString(const String& str, DocumentWriter& writer)
+inline void PagePopupClient::addString(const String& str, SharedBuffer* data)
 {
     CString str8 = str.utf8();
-    writer.addData(str8.data(), str8.length());
+    data->append(str8.data(), str8.length());
 }
 
 }
 #endif