Issue 120493004: Set m_pos as private in InlineIterator, and use getter and setter functions

Issue 120493004: Set m_pos as private in InlineIterator, and use getter and setter functions (Closed)

Created:
6 years, 12 months ago by gyuyoung-inactive

Modified:
6 years, 11 months ago

Reviewers:
pdr.

CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Set m_pos as private in InlineIterator, and use getter and setter functions InlineIterator has been exported m_pos as public directly though it is member variable. This patch set it as private, and add getter/setter functions for it. Merge from WebKit r161085. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164374

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -65 lines)			Patch
M	Source/core/rendering/InlineIterator.h	View	1	7 chunks	+15 lines, -17 lines	0 comments	Download
M	Source/core/rendering/RenderBlockLineLayout.cpp	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/rendering/line/BreakingContextInlineHeaders.h	View	1	21 chunks	+43 lines, -43 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pdr.

LGTM https://codereview.chromium.org/120493004/diff/1/Source/core/rendering/InlineIterator.h File Source/core/rendering/InlineIterator.h (right): https://codereview.chromium.org/120493004/diff/1/Source/core/rendering/InlineIterator.h#newcode106 Source/core/rendering/InlineIterator.h:106: // FIXME: These should be private. Please remove ...

6 years, 11 months ago (2013-12-30 01:05:15 UTC) #2

gyuyoung-inactive

https://codereview.chromium.org/120493004/diff/1/Source/core/rendering/InlineIterator.h File Source/core/rendering/InlineIterator.h (right): https://codereview.chromium.org/120493004/diff/1/Source/core/rendering/InlineIterator.h#newcode106 Source/core/rendering/InlineIterator.h:106: // FIXME: These should be private. On 2013/12/30 01:05:16, ...

6 years, 11 months ago (2013-12-30 01:07:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/120493004/80001

6 years, 11 months ago (2013-12-30 09:34:34 UTC) #4

Message was sent while issue was closed.

Change committed as 164374

Expand Messages | Collapse Messages