Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 12049039: Fix source position for stack traces with optimized top function. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: avoid default arguments by using pending_deoptimization_env_ Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 17448)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -690,7 +690,11 @@
type_args,
value_type,
Symbols::Value());
- InsertBefore(call, assert_value, NULL, Definition::kValue);
+ // Newly inserted instructions that can deoptimize or throw an exception
+ // must have a deoptimization id that is valid for lookup in the unoptimized
+ // code.
+ assert_value->deopt_id_ = call->deopt_id();
+ InsertBefore(call, assert_value, call->env(), Definition::kValue);
}
Value* array = NULL;

Powered by Google App Engine
This is Rietveld 408576698