runtime/vm/stack_frame.h - Issue 12049039: Fix source position for stack traces with optimized top function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stack_frame.h

Issue 12049039: Fix source position for stack traces with optimized top function. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: avoid default arguments by using pending_deoptimization_env_ Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stack_frame.h

===================================================================

--- runtime/vm/stack_frame.h (revision 17448)

+++ runtime/vm/stack_frame.h (working copy)

@@ -232,13 +232,14 @@

class InlinedFunctionsInDartFrameIterator : public ValueObject {

public:

explicit InlinedFunctionsInDartFrameIterator(StackFrame* frame);

- RawFunction* GetNextFunction(uword* pc);

+ RawFunction* GetNextFunction(uword* pc, Code* code);

private:

intptr_t index_;

StackFrame* frame_;

Function& func_;

DeoptInfo& deopt_info_;

+ GrowableArray<DeoptInstr*> deopt_instructions_;

siva 2013/01/28 22:46:55 See comment about adding this array in stack_frame

Florian Schneider 2013/01/29 12:19:07 I simplified the code for the iterator a bit (see

Array& object_table_;

DISALLOW_COPY_AND_ASSIGN(InlinedFunctionsInDartFrameIterator);

« runtime/vm/flow_graph_compiler.h ('K') | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/stack_frame.cc » ('j') | runtime/vm/stack_frame.cc » ('J')