Issue 1202303002: Revert of Fix incorrect libxml fprintf, erroring on clang win x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1202303002: Revert of Fix incorrect libxml fprintf, erroring on clang win x64 (Closed)

Created:
5 years, 6 months ago by scottmg

Modified:
5 years, 6 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Fix incorrect libxml fprintf, erroring on clang win x64 (patchset #1 id:1 of https://codereview.chromium.org/1204813002/) Reason for revert: Broke cast android whatever that is. http://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%29/builds/1035 Original issue's description: > Fix incorrect libxml fprintf, erroring on clang win x64 > > R=thakis@chromium.org > BUG=https://bugzilla.gnome.org/show_bug.cgi?id=751410 > BUG=82385 > > Committed: https://crrev.com/73a2484753cd6b2e4af673cd6dc752ba5b00c116 > Cr-Commit-Position: refs/heads/master@{#335736} TBR=thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=https://bugzilla.gnome.org/show_bug.cgi?id=751410 Committed: https://crrev.com/4ed482e45fad1c2e9eb9cd6a8f97ffecf6b66c5c Cr-Commit-Position: refs/heads/master@{#335743}

Created: 5 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	third_party/libxml/README.chromium	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	third_party/libxml/src/timsort.h	View		2 chunks	+1 line, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

scottmg

Created Revert of Fix incorrect libxml fprintf, erroring on clang win x64

5 years, 6 months ago (2015-06-23 20:47:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202303002/1

5 years, 6 months ago (2015-06-23 20:48:48 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-23 20:51:38 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4ed482e45fad1c2e9eb9cd6a8f97ffecf6b66c5c
Cr-Commit-Position: refs/heads/master@{#335743}