Issue 1204773003: Revert of Refactor GrBufferAllocPools to use resource cache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1204773003: Revert of Refactor GrBufferAllocPools to use resource cache (Closed)

Created:
5 years, 6 months ago by robertphillips

Modified:
5 years, 6 months ago

Reviewers:
joshualitt, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Refactor GrBufferAllocPools to use resource cache (patchset #15 id:280001 of https://codereview.chromium.org/1139753002/) Reason for revert: Will reland after Chromium branch Original issue's description: > Refactor GrBufferAllocPools to use resource cache > > Committed: https://skia.googlesource.com/skia/+/e935f1a0e2351373c33600b8388492ce1218014a TBR=bsalomon@google.com,joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/b607767703ff7898611cf88c1218d5d69535e984

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+149 lines, -170 lines)			Patch
M	include/gpu/GrCaps.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	include/gpu/GrTextureProvider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrBatchTarget.h	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/gpu/GrBatchTarget.cpp	View	2 chunks	+15 lines, -4 lines	0 comments	Download
M	src/gpu/GrBufferAllocPool.h	View	6 chunks	+29 lines, -9 lines	0 comments	Download
M	src/gpu/GrBufferAllocPool.cpp	View	13 chunks	+91 lines, -37 lines	0 comments	Download
M	src/gpu/GrCaps.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	src/gpu/GrIndexBuffer.h	View	2 chunks	+1 line, -16 lines	0 comments	Download
M	src/gpu/GrResourceProvider.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/gpu/GrResourceProvider.cpp	View	2 chunks	+1 line, -56 lines	0 comments	Download
M	src/gpu/GrVertexBuffer.h	View	1 chunk	+1 line, -16 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

robertphillips

Created Revert of Refactor GrBufferAllocPools to use resource cache

5 years, 6 months ago (2015-06-23 19:35:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204773003/1

5 years, 6 months ago (2015-06-23 19:36:04 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-23 19:36:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b607767703ff7898611cf88c1218d5d69535e984