chrome/android/java/res/layout/website_settings.xml - Issue 12045081: Android implementation of WebsiteSettingsUi

Unified Diff: chrome/android/java/res/layout/website_settings.xml

Issue 12045081: Android implementation of WebsiteSettingsUi (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix memory leak Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/res/layout/website_settings.xml

diff --git a/chrome/android/java/res/layout/website_settings.xml b/chrome/android/java/res/layout/website_settings.xml

new file mode 100644

index 0000000000000000000000000000000000000000..3f730b2a356830a347c26c9f5f9ffcad88e336e1

--- /dev/null

+++ b/chrome/android/java/res/layout/website_settings.xml

@@ -0,0 +1,29 @@

+<?xml version="1.0" encoding="utf-8"?>

Ted C 2013/01/25 02:04:05 copyright?

Yaron 2013/01/25 19:25:17 Done.

+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

+ android:orientation="horizontal"

+ android:layout_width="fill_parent"

Ted C 2013/01/25 02:04:05 Sadly, I don't think you get warnings about it, bu

Yaron 2013/01/25 19:25:17 Done.

+ android:layout_height="fill_parent"

+ android:paddingTop="@dimen/certificate_viewer_padding"

+ android:paddingBottom="@dimen/certificate_viewer_padding"

+ >

+ <ImageView android:id="@+id/website_settings_icon"

+ android:layout_width="wrap_content"

+ android:layout_height="wrap_content"

+ android:paddingLeft="@dimen/certificate_viewer_padding" />

+ <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

+ android:orientation="vertical"

+ android:layout_width="wrap_content"

+ android:layout_height="wrap_content"

+ android:paddingLeft="@dimen/certificate_viewer_padding"

+ android:paddingRight="@dimen/certificate_viewer_padding"

+ >

+ <TextView android:id="@+id/website_settings_headline"

+ android:layout_width="wrap_content"

Ted C 2013/01/25 02:04:05 indent here looks off as it's aligned with the abo

Yaron 2013/01/25 19:25:17 there seems to be some inconsistencies in our xml

+ android:layout_height="wrap_content"

+ />

+ <TextView android:id="@+id/website_settings_description"

+ android:layout_width="wrap_content"

+ android:layout_height="wrap_content"

+ />

+ </LinearLayout>

+</LinearLayout>

« no previous file with comments | « no previous file | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/res/values/strings.xml » ('J')