chrome/android/java/res/layout/website_settings.xml - Issue 12045081: Android implementation of WebsiteSettingsUi

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/website_settings.xml

Issue 12045081: Android implementation of WebsiteSettingsUi (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix memory leak Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	Ted C 2013/01/25 02:04:05 copyright? copyright? Yaron 2013/01/25 19:25:17 Done. Show quoted text On 2013/01/25 02:04:05, Ted C wrote: > copyright? Done.
	2 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	3 android:orientation="horizontal"

	4 android:layout_width="fill_parent"
	Ted C 2013/01/25 02:04:05 Sadly, I don't think you get warnings about it, bu Sadly, I don't think you get warnings about it, but fill_parent has been replaced by match_parent and is deprecated. http://developer.android.com/reference/android/view/ViewGroup.LayoutParams.ht... Yaron 2013/01/25 19:25:17 Done. Show quoted text On 2013/01/25 02:04:05, Ted C wrote: > Sadly, I don't think you get warnings about it, but fill_parent has been > replaced by match_parent and is deprecated. > > http://developer.android.com/reference/android/view/ViewGroup.LayoutParams.ht... Done.
	5 android:layout_height="fill_parent"

	6 android:paddingTop="@dimen/certificate_viewer_padding"

	7 android:paddingBottom="@dimen/certificate_viewer_padding"

	8 >

	9 <ImageView android:id="@+id/website_settings_icon"

	10 android:layout_width="wrap_content"

	11 android:layout_height="wrap_content"

	12 android:paddingLeft="@dimen/certificate_viewer_padding" />

	13 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	14 android:orientation="vertical"

	15 android:layout_width="wrap_content"

	16 android:layout_height="wrap_content"

	17 android:paddingLeft="@dimen/certificate_viewer_padding"

	18 android:paddingRight="@dimen/certificate_viewer_padding"

	19 >

	20 <TextView android:id="@+id/website_settings_headline"

	21 android:layout_width="wrap_content"
	Ted C 2013/01/25 02:04:05 indent here looks off as it's aligned with the abo indent here looks off as it's aligned with the above and this a child node. Yaron 2013/01/25 19:25:17 there seems to be some inconsistencies in our xml Show quoted text On 2013/01/25 02:04:05, Ted C wrote: > indent here looks off as it's aligned with the above and this a child node. there seems to be some inconsistencies in our xml files. I went for 2 indents for children, and then lining up attributes with the first line.
	22 android:layout_height="wrap_content"

	23 />

	24 <TextView android:id="@+id/website_settings_description"

	25 android:layout_width="wrap_content"

	26 android:layout_height="wrap_content"

	27 />

	28 </LinearLayout>

	29 </LinearLayout>

OLD	NEW

« no previous file with comments | « no previous file | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/res/values/strings.xml » ('J')