chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc - Issue 12045037: Refactor modality-specific behavior from ConstrainedWindowViews to WebContentsModalDialogManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc

Issue 12045037: Refactor modality-specific behavior from ConstrainedWindowViews to WebContentsModalDialogManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/web_contents_modal_dialog_manager_ui_delegate.h ('K') | « chrome/browser/ui/web_contents_modal_dialog_manager_unittest.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | ui/views/widget/widget.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc

index 1f1321928f2a917ec5a798ad15dc177514489b75..ab4c6deadf3692f953d8cb346623733eba2542f2 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc

+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc

@@ -270,6 +270,7 @@ TEST_F(PrintPreviewUIUnitTest, InitiatorTabGetsFocusOnPrintPreviewDialogClose) {

ASSERT_TRUE(preview_ui != NULL);

preview_ui->OnPrintPreviewDialogClosed();

+ message_loop()->RunUntilIdle();

EXPECT_EQ(2, browser()->tab_strip_model()->count());

EXPECT_FALSE(IsShowingWebContentsModalDialog(initiator_tab));