Refactor modality-specific behavior from ConstrainedWindowViews to WebContentsModalDialogManager

chrome/browser/ui/web_contents_modal_dialog_manager_ui_delegate.h

Index: chrome/browser/ui/web_contents_modal_dialog_manager_ui_delegate.h
diff --git a/chrome/browser/ui/web_contents_modal_dialog_manager_ui_delegate.h b/chrome/browser/ui/web_contents_modal_dialog_manager_ui_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..e97668b59a6dabe167858843336a92679cb2a1b1
--- /dev/null
+++ b/chrome/browser/ui/web_contents_modal_dialog_manager_ui_delegate.h
@@ -0,0 +1,29 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_WEB_CONTENTS_MODAL_DIALOG_MANAGER_UI_DELEGATE_H_
+#define CHROME_BROWSER_UI_WEB_CONTENTS_MODAL_DIALOG_MANAGER_UI_DELEGATE_H_
+
+#include "ui/gfx/native_widget_types.h"
+
+// Provides an interface for platform-specific UI implementation for the web
+// contents modal dialog.
+class WebContentsModalDialogManagerUIDelegate {

[Ben Goodger (Google), 2013/01/23 19:10:46]

the "UIDelegate" part here is a little confusing to me... well frankly our use
of a lot of these component words in our class names are confusing at this
point.

NativeWebContentsModalDialogManager

is a couple of characters shorter, and matches the intent (platform interface).
it's not vastly superior so I'm open to other suggestions... it's just
consistent with some other interfaces we use, e.g. NativeWidget, etc.

[Mike Wittman, 2013/01/23 21:52:31]

NativeWebContentsModalDialogManager sounds reasonable to me.  I wasn't sure how
to name this concept.

+ public:
+  WebContentsModalDialogManagerUIDelegate() {}
+  virtual ~WebContentsModalDialogManagerUIDelegate() {}
+
+  // Starts management of the modal aspects of the dialog.  This function should
+  // also register to be notified when the dialog is closing, so that it can
+  // notify the manager.
+  virtual void ManageDialog(gfx::NativeWindow window) = 0;
+
+  // Closes the web contents modal dialog.
+  virtual void CloseDialog(gfx::NativeWindow window) = 0;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(WebContentsModalDialogManagerUIDelegate);
+};
+
+#endif  // CHROME_BROWSER_UI_WEB_CONTENTS_MODAL_DIALOG_MANAGER_UI_DELEGATE_H_