chrome/browser/ui/views/web_intent_picker_views.cc - Issue 12045037: Refactor modality-specific behavior from ConstrainedWindowViews to WebContentsModalDialogManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/web_intent_picker_views.cc

Issue 12045037: Refactor modality-specific behavior from ConstrainedWindowViews to WebContentsModalDialogManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc ('K') | « chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc ('k') | chrome/browser/ui/web_contents_modal_dialog_manager.h » ('j') | chrome/browser/ui/web_contents_modal_dialog_manager_ui_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/web_intent_picker_views.cc

diff --git a/chrome/browser/ui/views/web_intent_picker_views.cc b/chrome/browser/ui/views/web_intent_picker_views.cc

index 5ff8024b7e4db28a158e6dee2399ad13cbcccfdb..c8f3af40882562444a4bc1c6783f21dae7e1baa4 100644

--- a/chrome/browser/ui/views/web_intent_picker_views.cc

+++ b/chrome/browser/ui/views/web_intent_picker_views.cc

@@ -1090,7 +1090,7 @@ WebIntentPickerViews::WebIntentPickerViews(WebContents* web_contents,

chrome_style::GetBackgroundColor()));

// Show the dialog.

- window_ = new ConstrainedWindowViews(web_contents, this);

+ window_ = ConstrainedWindowViews::Create(web_contents, this);

if (model_->IsInlineDisposition())

OnInlineDisposition(string16(), model_->inline_disposition_url());

else