Begin kLegacyFontHost_InitType cleanup

include/core/SkBitmapDevice.h

Index: include/core/SkBitmapDevice.h
diff --git a/include/core/SkBitmapDevice.h b/include/core/SkBitmapDevice.h
index 3ce06b0cc3e90b64ed4516b4b2a9dbc2db8fee2e..93f004ff0b21b01b42e8e9296fe92570a3cabc5a 100644
--- a/include/core/SkBitmapDevice.h
+++ b/include/core/SkBitmapDevice.h
@@ -20,21 +20,19 @@ public:
      *  Construct a new device with the specified bitmap as its backend. It is
      *  valid for the bitmap to have no pixels associated with it. In that case,
      *  any drawing to this device will have no effect.
-    */
+     */
     SkBitmapDevice(const SkBitmap& bitmap);
-protected:
+
+    static SkBitmapDevice* Create(const SkImageInfo& info);

[reed1, 2015/06/22 15:44:57]

Can we add dox to this factory?
- does it alloc pixels?
- who might call it?
- will it remain public long-term?
- what does it do for Props, since there aren't any specified?
- do we still need to make the associated constructor public?

[robertphillips, 2015/06/22 16:10:51]

Done. I have added documentation but this is just the old factory method from
below just moved up. I would like to completely remove this entry point and its
matching ctor but that is going to take some Chromium/Blink work (implausibly
BitmapPlatformDevice derives from SkBitmapDevice).

+
     /**
      *  Construct a new device with the specified bitmap as its backend. It is
      *  valid for the bitmap to have no pixels associated with it. In that case,
      *  any drawing to this device will have no effect.
-    */
+     */
     SkBitmapDevice(const SkBitmap& bitmap, const SkSurfaceProps& surfaceProps);
-private:
-    static SkBitmapDevice* Create(const SkImageInfo&, const SkSurfaceProps*);
-public:
-    static SkBitmapDevice* Create(const SkImageInfo& info) {
-        return Create(info, NULL);
-    }
+
+    static SkBitmapDevice* Create(const SkImageInfo&, const SkSurfaceProps&);
 
     SkImageInfo imageInfo() const override;