Begin kLegacyFontHost_InitType cleanup

include/core/SkBitmapDevice.h

 
 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkBitmapDevice_DEFINED
 #define SkBitmapDevice_DEFINED
 
 #include "SkDevice.h"
 
 ///////////////////////////////////////////////////////////////////////////////
 class SK_API SkBitmapDevice : public SkBaseDevice {
 public:
     SK_DECLARE_INST_COUNT(SkBitmapDevice)
 
     /**
      *  Construct a new device with the specified bitmap as its backend. It is
      *  valid for the bitmap to have no pixels associated with it. In that case,
      *  any drawing to this device will have no effect.
-    */
+     */
     SkBitmapDevice(const SkBitmap& bitmap);
-protected:
+
+    static SkBitmapDevice* Create(const SkImageInfo& info);

[reed1, 2015/06/22 15:44:57]

Can we add dox to this factory?
- does it alloc pixels?
- who might call it?
- will it remain public long-term?
- what does it do for Props, since there aren't any specified?
- do we still need to make the associated constructor public?

[robertphillips, 2015/06/22 16:10:51]

Done. I have added documentation but this is just the old factory method from
below just moved up. I would like to completely remove this entry point and its
matching ctor but that is going to take some Chromium/Blink work (implausibly
BitmapPlatformDevice derives from SkBitmapDevice).

+
     /**
      *  Construct a new device with the specified bitmap as its backend. It is
      *  valid for the bitmap to have no pixels associated with it. In that case,
      *  any drawing to this device will have no effect.
-    */
+     */
     SkBitmapDevice(const SkBitmap& bitmap, const SkSurfaceProps& surfaceProps);
-private:
-    static SkBitmapDevice* Create(const SkImageInfo&, const SkSurfaceProps*);
-public:
-    static SkBitmapDevice* Create(const SkImageInfo& info) {
-        return Create(info, NULL);
-    }
+
+    static SkBitmapDevice* Create(const SkImageInfo&, const SkSurfaceProps&);
 
     SkImageInfo imageInfo() const override;
 
 protected:
     bool onShouldDisableLCD(const SkPaint&) const override;
 
     /** These are called inside the per-device-layer loop for each draw call.
      When these are called, we have already applied any saveLayer operations,
      and are handling any looping from the paint, and any effects from the
      DrawFilter.
@@ skipping 97 matching lines @@
     SkImageFilter::Cache* getImageFilterCache() override;
 
     SkBitmap    fBitmap;
 
     void setNewSize(const SkISize&);  // Used by SkCanvas for resetForNextPicture().
 
     typedef SkBaseDevice INHERITED;
 };
 
 #endif // SkBitmapDevice_DEFINED