Begin kLegacyFontHost_InitType cleanup

Begin kLegacyFontHost_InitType cleanup


This CL starts the process of pushing kLegacyFontHost_InitType-type SkSurfaceProps up the call stack and out of Skia. It:

 Gets rid of the default SkBaseDevice ctor. This means everyone has to always hand an explicit SkSurfaceProps to it.

 It makes public the SkBitmapDevice creation methods that require SkSurfaceProps.

 Removes (in Skia's code base) all SkBitmapDevice ctor calls w/o SkSurfaceProps.

 Makes the "recording" canvases (e.g., pdf, svg, xps) explicitly not use kLegacyFontHost_InitType.

 Replicates the creating canvas/device's flags on saveLayer devices

BUG=skia:3934
Committed: https://skia.googlesource.com/skia/+/9a53fd7c41554630124522f4b6eedc16912abbb7

[robertphillips, 2015-06-22 15:37:34]

robertphillips@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-06-22 15:44:58]

https://codereview.chromium.org/1204433002/diff/20001/include/core/SkBitmapDe...
File include/core/SkBitmapDevice.h (right):

https://codereview.chromium.org/1204433002/diff/20001/include/core/SkBitmapDe...
include/core/SkBitmapDevice.h:26: static SkBitmapDevice* Create(const
SkImageInfo& info);
Can we add dox to this factory?
- does it alloc pixels?
- who might call it?
- will it remain public long-term?
- what does it do for Props, since there aren't any specified?
- do we still need to make the associated constructor public?

[robertphillips, 2015-06-22 16:10:51]

https://codereview.chromium.org/1204433002/diff/20001/include/core/SkBitmapDe...
File include/core/SkBitmapDevice.h (right):

https://codereview.chromium.org/1204433002/diff/20001/include/core/SkBitmapDe...
include/core/SkBitmapDevice.h:26: static SkBitmapDevice* Create(const
SkImageInfo& info);
On 2015/06/22 15:44:57, reed1 wrote:
> Can we add dox to this factory?
> - does it alloc pixels?
> - who might call it?
> - will it remain public long-term?
> - what does it do for Props, since there aren't any specified?
> - do we still need to make the associated constructor public?

Done. I have added documentation but this is just the old factory method from
below just moved up. I would like to completely remove this entry point and its
matching ctor but that is going to take some Chromium/Blink work (implausibly
BitmapPlatformDevice derives from SkBitmapDevice).

[reed1, 2015-06-22 16:14:12]

lgtm

[robertphillips, 2015-06-22 16:41:00]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-22 16:41:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1204433002/40001

[commit-bot: I haz the power, 2015-06-22 16:45:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-22 16:45:44]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-06-22 16:46:02]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-06-22 16:46:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1204433002/40001

[commit-bot: I haz the power, 2015-06-22 16:47:02]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/9a53fd7c41554630124522f4b6eedc16912abbb7