utils/pub/validator/lib.dart - Issue 12042053: Get rid of unneeded Future.immediate() calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/pub/validator/lib.dart

Issue 12042053: Get rid of unneeded Future.immediate() calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: utils/pub/validator/lib.dart

diff --git a/utils/pub/validator/lib.dart b/utils/pub/validator/lib.dart

index c9c5aba4a6f8ea53d1bc084e57333dfb909b6f30..e6798476f191065fc7e92810b6bc3cf538dc85f6 100644

--- a/utils/pub/validator/lib.dart

+++ b/utils/pub/validator/lib.dart

@@ -27,7 +27,7 @@ class LibValidator extends Validator {

if (!libDirExists) {

errors.add('You must have a "lib" directory.\n'

"Without that, users cannot import any code from your package.");

- return new Future.immediate(null);

+ return;

}

return listDir(libDir).then((files) {